Changeset 130931 in webkit for trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

Timestamp:

Oct 10, 2012, 11:08:03 AM (13 years ago)

Author:

[email protected]

Message:

After r130344, OpaqueJSString::string() shouldn't directly return the wrapped String
​https://bugs.webkit.org/show_bug.cgi?id=98801

Reviewed by Geoffrey Garen.

Return a copy of the wrapped String so that the wrapped string cannot be turned into
an Identifier.

• API/OpaqueJSString.cpp:

(OpaqueJSString::string):

• API/OpaqueJSString.h:

(OpaqueJSString):

File:

• trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

@@ -40 +40 @@
 }
 
+String OpaqueJSString::string() const
+{
+    if (!this)
+        return String();
+
+    // Return a copy of the wrapped string, because the caller may make it an Identifier.
+    return m_string.isolatedCopy();
+}
+
 Identifier OpaqueJSString::identifier(JSGlobalData* globalData) const
 {