Changeset 136246 in webkit for trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

Timestamp:

Nov 30, 2012, 8:59:03 AM (13 years ago)

Author:

[email protected]

Message:

Crash in conversion of empty OpaqueJSString to Identifier
​https://bugs.webkit.org/show_bug.cgi?id=101867

Reviewed by Michael Saboff.

The constructor call used for both null and empty OpaqueJSStrings results
in an assertion voilation and crash. This patch instead uses the Identifier
constructors which are specifically for null and empty Identifier.

• API/OpaqueJSString.cpp:

(OpaqueJSString::identifier):

File:

• trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

@@ -51 +51 @@
 Identifier OpaqueJSString::identifier(JSGlobalData* globalData) const
 {
-    if (!this || !m_string.length())
-        return Identifier(globalData, static_cast<const char*>(0));
+    if (!this || m_string.isNull())
+        return Identifier();
+
+    if (m_string.isEmpty())
+        return Identifier(Identifier::EmptyIdentifier);
 
     if (m_string.is8Bit())