Changeset 148720 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

Timestamp:

Apr 18, 2013, 6:34:07 PM (12 years ago)

Author:

[email protected]

Message:

StackFrame::column() returning bogus value
​https://bugs.webkit.org/show_bug.cgi?id=114840

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Don't add one part of the expression offset to the other part of the expression.
Make StackFrame::toString() include the column info.

• interpreter/Interpreter.cpp:

(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):

LayoutTests:

Update test result

• fast/js/stack-trace-expected.txt:

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

@@ -699 +699 @@
 {
     codeBlock->expressionRangeForBytecodeOffset(bytecodeOffset, divot, startOffset, endOffset);
-    divot += startOffset;
+    divot += characterOffset;
 }
 
@@ -715 +715 @@
             traceBuild.append(':');
             traceBuild.appendNumber(line());
+            traceBuild.append(':');
+            traceBuild.appendNumber(column());
         }
     }