Changeset 149134 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

Timestamp:

Apr 25, 2013, 12:54:53 PM (12 years ago)

Author:

[email protected]

Message:

JSC: Fix interpreter misbehavior in builds with JIT disabled
​https://bugs.webkit.org/show_bug.cgi?id=115190

Patch by Nick Diego Yamane <​[email protected]> on 2013-04-25
Reviewed by Oliver Hunt.

Commit ​http://trac.webkit.org/changeset/147858 modified
some details on how JS stack traces are built. The method
"getLineNumberForCallFrame", renamed in that changeset to
"getBytecodeOffsetForCallFrame" is always returning `0' when
JIT is disabled

How to reproduce:

• Build webkit with JIT disabled
• Open MiniBrowser, for example, with ​http://google.com
• In a debug build, WebProcess will hit the following ASSERT: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:279 ASSERT(low);

• interpreter/Interpreter.cpp:

(JSC::getBytecodeOffsetForCallFrame):

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

@@ -571 +571 @@
     if (!codeBlock)
         return 0;
-#if ENABLE(JIT)
 #if ENABLE(DFG_JIT)
     if (codeBlock->getJITType() == JITCode::DFGJIT)
@@ -577 +576 @@
 #endif
     return callFrame->bytecodeOffsetForNonDFGCode();
-#else
-    return 0;
-#endif
 }