Changeset 150644 in webkit for trunk/Source/JavaScriptCore/assembler/SH4Assembler.h

Timestamp:

May 24, 2013, 9:46:10 AM (12 years ago)

Author:

[email protected]

Message:

[sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=116716

Patch by Julien Brianceau <​[email protected]> on 2013-05-24
Reviewed by Geoffrey Garen.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::mul32): Cosmetic changes.
(JSC::MacroAssemblerSH4::convertInt32ToDouble): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::branch32): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch): Use all 32 bits of pointer for revertJump call.

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::revertJump): Use changePCrelativeAddress to patch the whole pointer.
(JSC::SH4Assembler::linkJump): Cosmetic change.

• offlineasm/sh4.rb: Optimize LLINT generated code.

File:

• trunk/Source/JavaScriptCore/assembler/SH4Assembler.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/assembler/SH4Assembler.h

@@ -1529 +1529 @@
     }
 
-    static void revertJump(void* instructionStart, SH4Word imm)
+    static void revertJump(void* instructionStart, void *immptr)
     {
         SH4Word *insn = reinterpret_cast<SH4Word*>(instructionStart);
-        SH4Word disp;
-
         ASSERT((insn[0] & 0xf000) == MOVL_READ_OFFPC_OPCODE);
-
-        disp = insn[0] & 0x00ff;
-        insn += 2 + (disp << 1); // PC += 4 + (disp*4)
-        insn = (SH4Word *) ((unsigned) insn & (~3));
-        insn[0] = imm;
-        cacheFlush(insn, sizeof(SH4Word));
+        changePCrelativeAddress(insn[0] & 0x00ff, insn, reinterpret_cast<uint32_t>(immptr));
     }
 
@@ -1594 +1587 @@
 
         instruction = *instructionPtr;
-        if ((instruction  & 0xf000) == 0xe000) {
+        if ((instruction & 0xf000) == 0xe000) {
             uint32_t* addr = getLdrImmAddressOnPool(instructionPtr, m_buffer.poolAddress());
             *addr = offsetBits - 2;