Changeset 153287 in webkit for trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

Timestamp:

Jul 24, 2013, 9:05:13 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: StringObjectUse uses structures, and CSE should know that
​https://bugs.webkit.org/show_bug.cgi?id=118940

Reviewed by Geoffrey Garen.

This is asymptomatic right now, but we should fix it.

• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

• dfg/DFGEdgeUsesStructure.h: Added.

(DFG):
(EdgeUsesStructure):
(JSC::DFG::EdgeUsesStructure::EdgeUsesStructure):
(JSC::DFG::EdgeUsesStructure::operator()):
(JSC::DFG::EdgeUsesStructure::result):
(JSC::DFG::edgesUseStructure):

• dfg/DFGUseKind.h:

(DFG):
(JSC::DFG::usesStructure):

Conflicts:

Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

File:

• trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

@@ -29 +29 @@
 #if ENABLE(DFG_JIT)
 
+#include "DFGEdgeUsesStructure.h"
 #include "DFGGraph.h"
 #include "DFGPhase.h"
@@ -611 +612 @@
             }
             if (m_graph.clobbersWorld(node) || node->canExit())
+                return 0;
+            if (edgesUseStructure(m_graph, node))
                 return 0;
         }