Ignore:
Timestamp:
Jul 24, 2013, 9:05:25 PM (12 years ago)
Author:
[email protected]
Message:

fourthTier: NodeExitsForward shouldn't be duplicated in NodeType
​https://bugs.webkit.org/show_bug.cgi?id=118956

Reviewed by Sam Weinig.

We had two way of expressing that something exits forward: the NodeExitsForward
flag and the word 'Forward' in the NodeType. That's kind of dumb. This patch
makes it just be a flag.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::willHaveCodeGenOrOSR):

  • dfg/DFGNodeType.h:

(DFG):
(JSC::DFG::needsOSRForwardRewiring):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

    r153287 r153292  
    141141            switch (otherNode->op()) {
    142142            case Int32ToDouble:
    143             case ForwardInt32ToDouble:
    144143                if (otherNode->child1() == node->child1())
    145144                    return otherNode;
    … …  
    449448            switch (node->op()) {
    450449            case CheckStructure:
    451             case ForwardCheckStructure:
    452450                if (node->child1() == child1
    453451                    && structureSet.isSupersetOf(node->structureSet()))
    … …  
    456454               
    457455            case StructureTransitionWatchpoint:
    458             case ForwardStructureTransitionWatchpoint:
    459456                if (node->child1() == child1
    460457                    && structureSet.contains(node->structure()))
    … …  
    508505            switch (node->op()) {
    509506            case CheckStructure:
    510             case ForwardCheckStructure:
    511507                if (node->child1() == child1
    512508                    && node->structureSet().containsOnly(structure))
    … …  
    533529               
    534530            case StructureTransitionWatchpoint:
    535             case ForwardStructureTransitionWatchpoint:
    536531                if (node->structure() == structure && node->child1() == child1)
    537532                    return true;
    … …  
    561556            switch (node->op()) {
    562557            case CheckStructure:
    563             case ForwardCheckStructure:
    564558                return 0;
    565559               
    … …  
    777771               
    778772            case CheckArray:
    779             case ForwardCheckArray:
    780773                if (node->child1() == child1 && node->arrayMode() == arrayMode)
    781774                    return true;
    … …  
    11051098           
    11061099        case Int32ToDouble:
    1107         case ForwardInt32ToDouble:
    11081100            if (cseMode == StoreElimination)
    11091101                break;
    … …  
    13061298           
    13071299        case CheckStructure:
    1308         case ForwardCheckStructure:
    13091300            if (cseMode == StoreElimination)
    13101301                break;
    … …  
    13141305           
    13151306        case StructureTransitionWatchpoint:
    1316         case ForwardStructureTransitionWatchpoint:
    13171307            if (cseMode == StoreElimination)
    13181308                break;
    … …  
    13421332               
    13431333        case CheckArray:
    1344         case ForwardCheckArray:
    13451334            if (cseMode == StoreElimination)
    13461335                break;
Note: See TracChangeset for help on using the changeset viewer.