Changeset 157558 in webkit for trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp

Timestamp:

Oct 16, 2013, 8:47:27 PM (12 years ago)

Author:

[email protected]

Message:

libllvmForJSC shouldn't call exit(1) on report_fatal_error()
​https://bugs.webkit.org/show_bug.cgi?id=122905
<rdar://problem/15237856>

Source/JavaScriptCore:

Reviewed by Michael Saboff.

Expose the new LLVMInstallFatalErrorHandler() API through the soft linking magic and
then always call it to install something that calls CRASH().

• llvm/InitializeLLVM.cpp:

(JSC::llvmCrash):
(JSC::initializeLLVMOnce):
(JSC::initializeLLVM):

• llvm/LLVMAPIFunctions.h:

WebKitLibraries:

Reviewed by Michael Saboff.

• LLVMIncludesMountainLion.tar.bz2:
• LLVMLibrariesMountainLion.tar.bz2:

File:

• trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp

@@ -29 +29 @@
 #if HAVE(LLVM)
 
+#include "LLVMAPI.h"
 #include <pthread.h>
 
@@ -35 +36 @@
 static pthread_once_t initializeLLVMOnceKey = PTHREAD_ONCE_INIT;
 
+static NO_RETURN_DUE_TO_CRASH void llvmCrash(const char* reason)
+{
+    WTFLogAlways("LLVM failure: %s", reason);
+    CRASH();
+}
+
+static void initializeLLVMOnce()
+{
+    initializeLLVMImpl();
+    
+    llvm->InstallFatalErrorHandler(llvmCrash);
+}
+
 void initializeLLVM()
 {
-    pthread_once(&initializeLLVMOnceKey, initializeLLVMImpl);
+    pthread_once(&initializeLLVMOnceKey, initializeLLVMOnce);
 }