Changeset 158509 in webkit for trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp

Timestamp:

Nov 2, 2013, 6:33:13 PM (12 years ago)

Author:

[email protected]

Message:

LLVM assertion failures should funnel into WTF's crash handling
​https://bugs.webkit.org/show_bug.cgi?id=123682

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Inside llvmForJSC, we override assertion-related functions and funnel them
into g_llvmTrapCallback(). We also now register a fatal error handler inside
the library and funnel that into g_llvmTrapCallback, and have
initializeAndGetJSCLLVMAPI() take such a callback as an argument.

Inside JSC, we no longer call LLVMInstallFatalErrorHandler() but instead we
pass WTFLogAlwaysAndCrash() as the trap callback for llvmForJSC.

• llvm/InitializeLLVM.cpp:

(JSC::initializeLLVM):

• llvm/InitializeLLVMPOSIX.cpp:

(JSC::initializeLLVMPOSIX):

• llvm/library/LLVMExports.cpp:

(llvmCrash):
(initializeAndGetJSCLLVMAPI):

• llvm/library/LLVMOverrides.cpp:

(raise):
(assert_rtn):
(abort):

• llvm/library/LLVMTrapCallback.h: Added.

Source/WTF:

Reviewed by Geoffrey Garen.

Give JSC some new toys to play with for crash handling.

• wtf/Assertions.cpp:
• wtf/Assertions.h:

Tools:

Reviewed by Geoffrey Garen.

Need to disable LLVM's crash overrides so that we can do our own crash overrides.

• Scripts/configure-llvm:

File:

• trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp

@@ -36 +36 @@
 static pthread_once_t initializeLLVMOnceKey = PTHREAD_ONCE_INIT;
 
-static NO_RETURN_DUE_TO_CRASH void llvmCrash(const char* reason)
-{
-    WTFLogAlways("LLVM failure: %s", reason);
-    CRASH();
-}
-
-static void initializeLLVMOnce()
-{
-    initializeLLVMImpl();
-    
-    llvm->InstallFatalErrorHandler(llvmCrash);
-}
-
 void initializeLLVM()
 {
-    pthread_once(&initializeLLVMOnceKey, initializeLLVMOnce);
+    pthread_once(&initializeLLVMOnceKey, initializeLLVMImpl);
 }