Changeset 159987 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h

Timestamp:

Dec 2, 2013, 5:32:43 PM (11 years ago)

Author:

[email protected]

Message:

Build failure when disabling JIT, YARR_JIT, and ASSEMBLER.
​https://bugs.webkit.org/show_bug.cgi?id=123809.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Also fixed build when disabling the DISASSEMBLER.
Added some needed #if's and some comments.

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

• dfg/DFGDisassembler.cpp:
• dfg/DFGDisassembler.h:

(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::setStartOfCode):
(JSC::DFG::Disassembler::setForBlockIndex):
(JSC::DFG::Disassembler::setForNode):
(JSC::DFG::Disassembler::setEndOfMainPath):
(JSC::DFG::Disassembler::setEndOfCode):
(JSC::DFG::Disassembler::dump):
(JSC::DFG::Disassembler::reportToProfiler):

• disassembler/Disassembler.cpp:
• disassembler/X86Disassembler.cpp:
• jit/FPRInfo.h:
• jit/GPRInfo.h:
• jit/JITDisassembler.cpp:
• jit/JITDisassembler.h:

(JSC::JITDisassembler::JITDisassembler):
(JSC::JITDisassembler::setStartOfCode):
(JSC::JITDisassembler::setForBytecodeMainPath):
(JSC::JITDisassembler::setForBytecodeSlowPath):
(JSC::JITDisassembler::setEndOfSlowPath):
(JSC::JITDisassembler::setEndOfCode):
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::reportToProfiler):

Source/WTF:

• wtf/Platform.h:
• Ensure that the ASSEMBLER is enabled when the DISASSEMBLER is enabled.

File:

• trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h

@@ -42 +42 @@
 
 class Graph;
+
+#if ENABLE(DISASSEMBLER)
 
 class Disassembler {
@@ -98 +100 @@
 };
 
+#else // ENABLE(DISASSEMBLER)
+
+class Disassembler {
+    WTF_MAKE_FAST_ALLOCATED;
+public:
+    Disassembler(Graph&) { }
+
+    void setStartOfCode(MacroAssembler::Label) { }
+    void setForBlockIndex(BlockIndex, MacroAssembler::Label) { }
+    void setForNode(Node*, MacroAssembler::Label) { }
+    void setEndOfMainPath(MacroAssembler::Label) { }
+    void setEndOfCode(MacroAssembler::Label) { }
+
+    void dump(LinkBuffer&) { }
+    void reportToProfiler(Profiler::Compilation*, LinkBuffer&) { }
+};
+
+#endif // ENABLE(DISASSEMBLER)
+
 } } // namespace JSC::DFG