Changeset 163760 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h

Timestamp:

Feb 9, 2014, 6:51:13 PM (11 years ago)

Author:

[email protected]

Message:

Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead
​https://bugs.webkit.org/show_bug.cgi?id=128505

Reviewed by Mark Hahnenberg and Oliver Hunt.

• API/JSContextRef.cpp:
• assembler/LinkBuffer.cpp:
• bytecode/ArrayProfile.cpp:
• bytecode/BytecodeBasicBlock.cpp:
• bytecode/BytecodeLivenessAnalysisInlines.h:
• bytecode/CallLinkInfo.cpp:
• bytecode/CodeBlock.cpp:
• bytecode/CodeBlock.h:
• bytecode/CodeBlockJettisoningWatchpoint.cpp:
• bytecode/ExecutionCounter.cpp:
• bytecode/MethodOfGettingAValueProfile.cpp:
• bytecode/PreciseJumpTargets.cpp:
• bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
• bytecode/SamplingTool.cpp:
• bytecode/SpecialPointer.cpp:
• bytecode/StructureStubClearingWatchpoint.cpp:
• debugger/DebuggerCallFrame.cpp:
• dfg/DFGAbstractHeap.cpp:
• dfg/DFGAbstractValue.cpp:
• dfg/DFGArgumentsSimplificationPhase.cpp:
• dfg/DFGArithMode.cpp:
• dfg/DFGArrayMode.cpp:
• dfg/DFGAtTailAbstractState.cpp:
• dfg/DFGAvailability.cpp:
• dfg/DFGBackwardsPropagationPhase.cpp:
• dfg/DFGBasicBlock.cpp:
• dfg/DFGBinarySwitch.cpp:
• dfg/DFGBlockInsertionSet.cpp:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCFAPhase.cpp:
• dfg/DFGCFGSimplificationPhase.cpp:
• dfg/DFGCPSRethreadingPhase.cpp:
• dfg/DFGCSEPhase.cpp:
• dfg/DFGCapabilities.cpp:
• dfg/DFGClobberSet.cpp:
• dfg/DFGClobberize.cpp:
• dfg/DFGCommon.cpp:
• dfg/DFGCommonData.cpp:
• dfg/DFGCompilationKey.cpp:
• dfg/DFGCompilationMode.cpp:
• dfg/DFGConstantFoldingPhase.cpp:
• dfg/DFGCriticalEdgeBreakingPhase.cpp:
• dfg/DFGDCEPhase.cpp:
• dfg/DFGDesiredIdentifiers.cpp:
• dfg/DFGDesiredStructureChains.cpp:
• dfg/DFGDesiredTransitions.cpp:
• dfg/DFGDesiredWatchpoints.cpp:
• dfg/DFGDisassembler.cpp:
• dfg/DFGDisassembler.h:
• dfg/DFGDominators.cpp:
• dfg/DFGEdge.cpp:
• dfg/DFGFailedFinalizer.cpp:
• dfg/DFGFinalizer.cpp:
• dfg/DFGFixupPhase.cpp:
• dfg/DFGFlushFormat.cpp:
• dfg/DFGFlushLivenessAnalysisPhase.cpp:
• dfg/DFGFlushedAt.cpp:
• dfg/DFGGraph.cpp:
• dfg/DFGInPlaceAbstractState.cpp:
• dfg/DFGInvalidationPointInjectionPhase.cpp:
• dfg/DFGJITCode.cpp:
• dfg/DFGJITCompiler.cpp:
• dfg/DFGJITCompiler.h:
• dfg/DFGJITFinalizer.cpp:
• dfg/DFGJumpReplacement.cpp:
• dfg/DFGLICMPhase.cpp:
• dfg/DFGLazyJSValue.cpp:
• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGLongLivedState.cpp:
• dfg/DFGLoopPreHeaderCreationPhase.cpp:
• dfg/DFGMinifiedNode.cpp:
• dfg/DFGNaturalLoops.cpp:
• dfg/DFGNode.cpp:
• dfg/DFGNodeFlags.cpp:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
• dfg/DFGOSREntry.cpp:
• dfg/DFGOSREntrypointCreationPhase.cpp:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOSRExitBase.cpp:
• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler32_64.cpp:
• dfg/DFGOSRExitCompiler64.cpp:
• dfg/DFGOSRExitCompilerCommon.cpp:
• dfg/DFGOSRExitJumpPlaceholder.cpp:
• dfg/DFGOSRExitPreparation.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPhase.cpp:
• dfg/DFGPlan.cpp:
• dfg/DFGPredictionInjectionPhase.cpp:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGResurrectionForValidationPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:
• dfg/DFGSSALoweringPhase.cpp:
• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT32_64.cpp:
• dfg/DFGSpeculativeJIT64.cpp:
• dfg/DFGStackLayoutPhase.cpp:
• dfg/DFGStoreBarrierElisionPhase.cpp:
• dfg/DFGStrengthReductionPhase.cpp:
• dfg/DFGThunks.cpp:
• dfg/DFGTierUpCheckInjectionPhase.cpp:
• dfg/DFGToFTLDeferredCompilationCallback.cpp:
• dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
• dfg/DFGTypeCheckHoistingPhase.cpp:
• dfg/DFGUnificationPhase.cpp:
• dfg/DFGUseKind.cpp:
• dfg/DFGValidate.cpp:
• dfg/DFGValueSource.cpp:
• dfg/DFGVariableAccessDataDump.cpp:
• dfg/DFGVariableEvent.cpp:
• dfg/DFGVariableEventStream.cpp:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:
• dfg/DFGWatchpointCollectionPhase.cpp:
• dfg/DFGWorklist.cpp:
• disassembler/Disassembler.cpp:
• ftl/FTLLink.cpp:
• ftl/FTLOSRExitCompiler.cpp:
• ftl/FTLSlowPathCall.cpp:
• ftl/FTLThunks.cpp:

(JSC::FTL::slowPathCallThunkGenerator):

• heap/BlockAllocator.cpp:
• heap/CodeBlockSet.cpp:
• heap/ConservativeRoots.cpp:
• heap/DeferGC.cpp:
• heap/GCThread.cpp:
• heap/GCThreadSharedData.cpp:
• heap/HeapTimer.cpp:
• heap/IncrementalSweeper.cpp:
• heap/JITStubRoutineSet.cpp:
• heap/MachineStackMarker.cpp:
• heap/MarkStack.cpp:
• heap/MarkedAllocator.cpp:
• heap/MarkedSpace.cpp:
• heap/SuperRegion.cpp:
• heap/Weak.cpp:
• heap/WeakHandleOwner.cpp:
• heap/WeakSet.cpp:
• heap/WriteBarrierBuffer.cpp:
• heap/WriteBarrierSupport.cpp:
• inspector/ScriptCallStackFactory.cpp:
• interpreter/AbstractPC.cpp:
• interpreter/JSStack.cpp:
• interpreter/ProtoCallFrame.cpp:
• interpreter/VMInspector.cpp:
• jit/ArityCheckFailReturnThunks.cpp:
• jit/AssemblyHelpers.cpp:
• jit/ExecutableAllocator.cpp:
• jit/ExecutableAllocatorFixedVMPool.cpp:
• jit/GCAwareJITStubRoutine.cpp:
• jit/HostCallReturnValue.cpp:
• jit/JITDisassembler.cpp:
• jit/JITDisassembler.h:
• jit/JITExceptions.cpp:
• jit/JITInlines.h:
• jit/JITOperations.cpp:
• jit/JITOperationsMSVC64.cpp:
• jit/JITStubRoutine.cpp:
• jit/JITStubs.cpp:
• jit/JITToDFGDeferredCompilationCallback.cpp:
• jit/RegisterPreservationWrapperGenerator.cpp:
• jit/RegisterSet.cpp:
• jit/Repatch.cpp:
• jit/TempRegisterSet.cpp:
• jsc.cpp:
• parser/Lexer.cpp:
• parser/Parser.cpp:
• parser/ParserArena.cpp:
• parser/SourceCode.cpp:
• parser/SourceProvider.cpp:
• parser/SourceProviderCache.cpp:
• profiler/ProfileGenerator.cpp:
• runtime/Arguments.cpp:
• runtime/ArgumentsIteratorPrototype.cpp:
• runtime/CommonSlowPathsExceptions.cpp:
• runtime/JSArgumentsIterator.cpp:
• runtime/JSFunction.cpp:
• runtime/JSGlobalObjectFunctions.cpp:
• runtime/ObjectConstructor.cpp:
• runtime/Operations.h:
• runtime/VM.cpp:

File:

• trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h

@@ -42 +42 @@
 
 class Graph;
-
-#if ENABLE(DISASSEMBLER)
 
 class Disassembler {
@@ -100 +98 @@
 };
 
-#else // ENABLE(DISASSEMBLER)
-
-class Disassembler {
-    WTF_MAKE_FAST_ALLOCATED;
-public:
-    Disassembler(Graph&) { }
-
-    void setStartOfCode(MacroAssembler::Label) { }
-    void setForBlockIndex(BlockIndex, MacroAssembler::Label) { }
-    void setForNode(Node*, MacroAssembler::Label) { }
-    void setEndOfMainPath(MacroAssembler::Label) { }
-    void setEndOfCode(MacroAssembler::Label) { }
-
-    void dump(LinkBuffer&) { }
-    void reportToProfiler(Profiler::Compilation*, LinkBuffer&) { }
-};
-
-#endif // ENABLE(DISASSEMBLER)
-
 } } // namespace JSC::DFG