Changeset 168107 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

May 1, 2014, 10:26:24 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r167964.
​https://bugs.webkit.org/show_bug.cgi?id=132431

Memory improvements should not regress memory usage (Requested
by olliej on #webkit).

Reverted changeset:

"Don't hold on to parameter BindingNodes forever"
​https://bugs.webkit.org/show_bug.cgi?id=132360
​http://trac.webkit.org/changeset/167964

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -1536 +1536 @@
         FunctionParameters* parameters() const { return m_parameters.get(); }
         size_t parameterCount() const { return m_parameters->size(); }
-        int parametersStartOffset() const { return m_parametersStart.endOffset; }
-        int parametersEndOffset() const { return m_parametersEnd.startOffset; }
 
         virtual void emitBytecode(BytecodeGenerator&, RegisterID* = 0) override;
@@ -1560 +1558 @@
         static const bool scopeIsFunction = true;
 
-        void setParameterLocation(const JSTokenLocation& openParen, const JSTokenLocation& closeParen)
-        {
-            m_parametersStart = openParen;
-            m_parametersEnd = closeParen;
-        }
     private:
         FunctionBodyNode(VM*, const JSTokenLocation& start, const JSTokenLocation& end, unsigned startColumn, unsigned endColumn, bool inStrictContext);
@@ -1573 +1566 @@
         FunctionMode m_functionMode;
         RefPtr<FunctionParameters> m_parameters;
-        JSTokenLocation m_parametersStart;
-        JSTokenLocation m_parametersEnd;
         int m_functionNameStart;
         unsigned m_startColumn;