Changeset 170381 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Jun 24, 2014, 12:49:25 PM (11 years ago)

Author:

Brent Fulgham

Message:

[Win] MSVC mishandles enums in bitfields
​https://bugs.webkit.org/show_bug.cgi?id=134237

Reviewed by Michael Saboff.

Replace uses of enum types in bit fields with unsigned to
avoid losing a bit to hold the sign value. This can result
in Windows interpreting the value of the field improperly.

../JavaScriptCore:

• bytecode/StructureStubInfo.h:
• parser/Nodes.h:

../WebCore:

• loader/ResourceLoaderOptions.h:
• platform/network/ResourceRequestBase.h:
• platform/network/cf/ResourceResponse.h:
• rendering/RenderLayer.h:
• rendering/RenderMarquee.h:

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -1041 +1041 @@
         ExpressionNode* m_subscript;
         ExpressionNode* m_right;
-        Operator m_operator : 30;
+        unsigned m_operator : 30;
         bool m_subscriptHasAssignments : 1;
         bool m_rightHasAssignments : 1;
@@ -1083 +1083 @@
         const Identifier& m_ident;
         ExpressionNode* m_right;
-        Operator m_operator : 31;
+        unsigned m_operator : 31;
         bool m_rightHasAssignments : 1;
     };