Changeset 171528 in webkit for trunk/Source/JavaScriptCore/replay/EncodedValue.cpp

Timestamp:

Jul 24, 2014, 3:11:12 PM (11 years ago)

Author:

Brian Burg

Message:

Web Replay: don't encode/decode primitive types that lack explicit sizes
​https://bugs.webkit.org/show_bug.cgi?id=133430

Reviewed by Anders Carlsson.

Source/JavaScriptCore:
Don't support encode/decode of unsigned long, since its size is compiler-dependent.

• replay/EncodedValue.cpp:

(JSC::EncodedValue::convertTo<unsigned long>):
(JSC::unsigned long>::encodeValue): Deleted.

• replay/EncodedValue.h:

Source/WebCore:
Remove uses of unsigned long in encode/decode methods because the type lacks an
explicit size. Move frame index serialization away from using unsigned long.

• replay/ReplayController.cpp:

(WebCore::logDispatchedDOMEvent): Fix the format string.

• replay/SerializationMethods.cpp:

(WebCore::frameIndexFromDocument):
(WebCore::frameIndexFromFrame):
(WebCore::documentFromFrameIndex):
(WebCore::frameFromFrameIndex):
(JSC::EncodingTraits<PluginData>::encodeValue):
(JSC::EncodingTraits<PluginData>::decodeValue):

• replay/SerializationMethods.h:
• replay/WebInputs.json: Remove primitive types without explicit sizes.

File:

• trunk/Source/JavaScriptCore/replay/EncodedValue.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/replay/EncodedValue.cpp

@@ -91 +91 @@
 }
 
-template<> EncodedValue ScalarEncodingTraits<unsigned long>::encodeValue(const unsigned long& value)
-{
-    return EncodedValue(InspectorBasicValue::create((double)value));
-}
-
 template<> bool EncodedValue::convertTo<bool>()
 {
@@ -159 +154 @@
 }
 
-template<> unsigned long EncodedValue::convertTo<unsigned long>()
-{
-    unsigned long result;
-    bool castSucceeded = m_value->asNumber(&result);
-    ASSERT_UNUSED(castSucceeded, castSucceeded);
-
-    return result;
-}
-
 template<> String EncodedValue::convertTo<String>()
 {