Changeset 171682 in webkit for trunk/Source/JavaScriptCore/replay/EncodedValue.cpp

Timestamp:

Jul 28, 2014, 12:21:15 PM (11 years ago)

Author:

Brian Burg

Message:

Web Replay: vectors of characters should be base64-encoded
​https://bugs.webkit.org/show_bug.cgi?id=135341

Reviewed by Timothy Hatcher.

Without this specialization, encode/decode methods try to create an
array of single characters in JSON, rather than treating the
vector as a binary blob.

• replay/EncodedValue.cpp:

(JSC::EncodingTraits<Vector<char>>::encodeValue): Added.
(JSC::EncodingTraits<Vector<char>>::decodeValue): Added.

• replay/EncodedValue.h:

File:

• trunk/Source/JavaScriptCore/replay/EncodedValue.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/replay/EncodedValue.cpp

@@ -56 +56 @@
 }
 
+EncodedValue EncodingTraits<Vector<char>>::encodeValue(const Vector<char>& buffer)
+{
+    return EncodedValue::createString(base64Encode(buffer));
+}
+
+bool EncodingTraits<Vector<char>>::decodeValue(EncodedValue& encodedBuffer, Vector<char>& decodedValue)
+{
+    return base64Decode(encodedBuffer.convertTo<String>(), decodedValue);
+}
+
 template<> EncodedValue ScalarEncodingTraits<bool>::encodeValue(const bool& value)
 {