Changeset 1850 in webkit for trunk/JavaScriptCore/kjs/value.cpp

Timestamp:

Aug 16, 2002, 12:07:48 PM (23 years ago)

Author:

mjs

Message:

Final step of the Reference change. Completely separate Reference
from Value, and eliminate ReferenceImp.

18% speedup on cvs-js-performance test.

• kjs/internal.cpp, kjs/internal.h: Remove ReferenceImp.
• kjs/nodes.cpp: (Node::evaluateReference): Use Reference::makeValueReference(), not ConstReference.
• kjs/reference.cpp: (Reference::Reference): New implementation, handles both regular and value references. (Reference::makeValueReference): Incorporate functionality of ConstReference into this class. (Reference::getBase): New implementation (incorporates error vase for value references). (Reference::getPropertyName): New implementation (incorporates error case for value references). (Reference::putValue): New implementation (incorporates error case for value references). (Reference::deleteValue): New implementation (incorporates error case for value references). (Reference::getValue): New implementation (incorporates special case for value references). (Reference::isMutable): New implementation.
• kjs/reference.h: New implementation that merges ReferenceImp into the stack object.
• kjs/value.h, kjs/value.cpp: Removed all reference-related method.

File:

• trunk/JavaScriptCore/kjs/value.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/value.cpp

@@ -141 +141 @@
 }
 
-// ECMA 8.7.1
-Value ValueImp::getBase(ExecState *exec) const
-{
-  Object err = Error::create(exec, ReferenceError, I18N_NOOP("Invalid reference base"));
-  exec->setException(err);
-  return err;
-}
-
-// ECMA 8.7.2
-UString ValueImp::getPropertyName(ExecState * /*exec*/) const
-{
-  // the spec wants a runtime error here. But getValue() and putValue()
-  // will catch this case on their own earlier. When returning a Null
-  // string we should be on the safe side.
-  return UString();
-}
-
-// ECMA 8.7.1
-Value ValueImp::getValue(ExecState *exec) const
-{
-  return Value(const_cast<ValueImp*>(this));
-}
-
-void ValueImp::putValue(ExecState *exec, const Value& w)
-{
-  Object err = Error::create(exec,ReferenceError);
-  exec->setException(err);
-}
-
-bool ValueImp::deleteValue(ExecState *exec)
-{
-  Object err = Error::create(exec,ReferenceError);
-  exec->setException(err);
-  return false;
-}
-
 // Dispatchers for virtual functions, to special-case simple numbers which
 // won't be real pointers.
@@ -234 +198 @@
 }
 
-Value ValueImp::dispatchGetBase(ExecState *exec) const
-{
-  if (SimpleNumber::is(this))
-    return ValueImp::getBase(exec);
-  return getBase(exec);
-}
-
-UString ValueImp::dispatchGetPropertyName(ExecState *exec) const
-{
-  if (SimpleNumber::is(this))
-    return ValueImp::getPropertyName(exec);
-  return getPropertyName(exec);
-}
-
-void ValueImp::dispatchPutValue(ExecState *exec, const Value& w)
-{
-  if (SimpleNumber::is(this))
-    ValueImp::putValue(exec, w);
-  putValue(exec, w);
-}
-
-bool ValueImp::dispatchDeleteValue(ExecState *exec)
-{
-  if (SimpleNumber::is(this))
-    return ValueImp::deleteValue(exec);
-  return deleteValue(exec);
-}
-
-
 // ------------------------------ Value ----------------------------------------