Changeset 2783 in webkit for trunk/JavaScriptCore/kjs/value.cpp

Timestamp:

Nov 20, 2002, 1:12:14 PM (23 years ago)

Author:

darin

Message:

• decrease ref/deref -- 5% speedup in iBench

• JavaScriptCore.pbproj/project.pbxproj: Added array_instance.h
• kjs/array_instance.h: Added so it can be shared by function.h.

• kjs/array_object.cpp:
• kjs/array_object.h:
• kjs/bool_object.cpp:
• kjs/bool_object.h:
• kjs/collector.cpp:
• kjs/date_object.cpp:
• kjs/date_object.h:
• kjs/error_object.cpp:
• kjs/function.cpp:
• kjs/function.h:
• kjs/function_object.cpp:
• kjs/internal.cpp:
• kjs/internal.h:
• kjs/math_object.cpp:
• kjs/nodes.cpp:
• kjs/number_object.cpp:
• kjs/object.cpp:
• kjs/object.h:
• kjs/object_object.cpp:
• kjs/property_map.cpp:
• kjs/reference.cpp:
• kjs/reference.h:
• kjs/regexp_object.cpp:
• kjs/string_object.cpp:
• kjs/string_object.h:
• kjs/value.cpp:
• kjs/value.h: Switched lots of interfaces so they don't require ref/deref.

File:

• trunk/JavaScriptCore/kjs/value.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/value.cpp

@@ -203 +203 @@
 {
   rep = v;
-  if (rep)
+  if (v)
   {
-    rep->ref();
+    v->ref();
     //fprintf(stderr, "Value::Value(%p) imp=%p ref=%d\n", this, rep, rep->refcount);
     v->setGcAllowed();
@@ -296 +296 @@
 // ------------------------------ String ---------------------------------------
 
-String::String(const UString &s) : Value(new StringImp(UString(s)))
+String::String(const UString &s) : Value(new StringImp(s))
 {
 }
@@ -323 +323 @@
 
 Number::Number(double d)
-  : Value(SimpleNumber::fits(d) ? SimpleNumber::make((long)d) : new NumberImp(d)) { }
+  : Value(SimpleNumber::fits(d) ? SimpleNumber::make((long)d) : (KJS::isNaN(d) ? NumberImp::staticNaN : new NumberImp(d))) { }
 
 Number::Number(long int l)
@@ -349 +349 @@
 int Number::intValue() const
 {
-  return int(value());
+  if (SimpleNumber::is(rep))
+    return SimpleNumber::value(rep);
+  return (int)((NumberImp*)rep)->value();
 }
 
 bool Number::isNaN() const
 {
-  return KJS::isNaN(value());
+  return rep == NumberImp::staticNaN;
 }
 
 bool Number::isInf() const
 {
-  return KJS::isInf(value());
-}
+  if (SimpleNumber::is(rep))
+    return false;
+  return KJS::isInf(((NumberImp*)rep)->value());
+}