Changeset 188529 in webkit for trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

Timestamp:

Aug 17, 2015, 11:28:19 AM (10 years ago)

Author:

Yusuke Suzuki

Message:

[ES6] Implement Reflect.getOwnPropertyDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=147929

Reviewed by Geoffrey Garen.

Implement Reflect.getOwnPropertyDescriptor.
The difference from the Object.getOwnPropertyDescriptor is
Reflect.getOwnPropertyDescriptor does not perform ToObject onto
the first argument. If the first argument is not an Object, it
immediately raises the TypeError.

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):

• runtime/ObjectConstructor.h:
• runtime/ReflectObject.cpp:

(JSC::reflectObjectGetOwnPropertyDescriptor):

• tests/stress/reflect-get-own-property.js: Added.

(shouldBe):
(shouldThrow):

File:

• trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

@@ -37 +37 @@
 static EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectEnumerate(ExecState*);
+static EncodedJSValue JSC_HOST_CALL reflectObjectGetOwnPropertyDescriptor(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectGetPrototypeOf(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectIsExtensible(ExecState*);
@@ -55 +56 @@
 /* Source for ReflectObject.lut.h
 @begin reflectObjectTable
-    apply             reflectObjectApply             DontEnum|Function 3
-    defineProperty    reflectObjectDefineProperty    DontEnum|Function 3
-    deleteProperty    reflectObjectDeleteProperty    DontEnum|Function 2
-    enumerate         reflectObjectEnumerate         DontEnum|Function 1
-    getPrototypeOf    reflectObjectGetPrototypeOf    DontEnum|Function 1
-    has               reflectObjectHas               DontEnum|Function 2
-    isExtensible      reflectObjectIsExtensible      DontEnum|Function 1
-    ownKeys           reflectObjectOwnKeys           DontEnum|Function 1
-    preventExtensions reflectObjectPreventExtensions DontEnum|Function 1
-    setPrototypeOf    reflectObjectSetPrototypeOf    DontEnum|Function 2
+    apply                    reflectObjectApply                    DontEnum|Function 3
+    defineProperty           reflectObjectDefineProperty           DontEnum|Function 3
+    deleteProperty           reflectObjectDeleteProperty           DontEnum|Function 2
+    enumerate                reflectObjectEnumerate                DontEnum|Function 1
+    getOwnPropertyDescriptor reflectObjectGetOwnPropertyDescriptor DontEnum|Function 2
+    getPrototypeOf           reflectObjectGetPrototypeOf           DontEnum|Function 1
+    has                      reflectObjectHas                      DontEnum|Function 2
+    isExtensible             reflectObjectIsExtensible             DontEnum|Function 1
+    ownKeys                  reflectObjectOwnKeys                  DontEnum|Function 1
+    preventExtensions        reflectObjectPreventExtensions        DontEnum|Function 1
+    setPrototypeOf           reflectObjectSetPrototypeOf           DontEnum|Function 2
 @end
 */
@@ -115 +117 @@
         return JSValue::encode(throwTypeError(exec, ASCIILiteral("Reflect.enumerate requires the first argument be an object")));
     return JSValue::encode(JSPropertyNameIterator::create(exec, exec->lexicalGlobalObject()->propertyNameIteratorStructure(), asObject(target)));
+}
+
+// http://www.ecma-international.org/ecma-262/6.0/#sec-reflect.getownpropertydescriptor
+EncodedJSValue JSC_HOST_CALL reflectObjectGetOwnPropertyDescriptor(ExecState* exec)
+{
+    JSValue target = exec->argument(0);
+    if (!target.isObject())
+        return JSValue::encode(throwTypeError(exec, ASCIILiteral("Reflect.getOwnPropertyDescriptor requires the first argument be an object")));
+
+    auto key = exec->argument(1).toPropertyKey(exec);
+    if (exec->hadException())
+        return JSValue::encode(jsUndefined());
+
+    return JSValue::encode(objectConstructorGetOwnPropertyDescriptor(exec, asObject(target), key));
 }