Changeset 188532 in webkit for trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

Timestamp:

Aug 17, 2015, 11:56:52 AM (10 years ago)

Author:

Yusuke Suzuki

Message:

[ES6] Implement Reflect.get
​https://bugs.webkit.org/show_bug.cgi?id=147925

Reviewed by Geoffrey Garen.

This patch implements Reflect.get API.
It can take the receiver object as the third argument.
When the receiver is specified and there's a getter for the given property name,
we call the getter with the receiver as the |this| value.

• runtime/ReflectObject.cpp:

(JSC::reflectObjectGet):

• runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::get): Deleted.

• runtime/SparseArrayValueMap.h:
• tests/stress/reflect-get.js: Added.

(shouldBe):
(shouldThrow):
(.get shouldThrow):
(.get var):
(get var.object.get hello):
(.get shouldBe):
(get var.object.set hello):

File:

• trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

@@ -37 +37 @@
 static EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectEnumerate(ExecState*);
+static EncodedJSValue JSC_HOST_CALL reflectObjectGet(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectGetOwnPropertyDescriptor(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectGetPrototypeOf(ExecState*);
@@ -60 +61 @@
     deleteProperty           reflectObjectDeleteProperty           DontEnum|Function 2
     enumerate                reflectObjectEnumerate                DontEnum|Function 1
+    get                      reflectObjectGet                      DontEnum|Function 2
     getOwnPropertyDescriptor reflectObjectGetOwnPropertyDescriptor DontEnum|Function 2
     getPrototypeOf           reflectObjectGetPrototypeOf           DontEnum|Function 1
@@ -119 +121 @@
 }
 
+// http://www.ecma-international.org/ecma-262/6.0/#sec-reflect.get
+EncodedJSValue JSC_HOST_CALL reflectObjectGet(ExecState* exec)
+{
+    JSValue target = exec->argument(0);
+    if (!target.isObject())
+        return JSValue::encode(throwTypeError(exec, ASCIILiteral("Reflect.get requires the first argument be an object")));
+
+    const Identifier propertyName = exec->argument(1).toPropertyKey(exec);
+    if (exec->hadException())
+        return JSValue::encode(jsNull());
+
+    JSValue receiver = target;
+    if (exec->argumentCount() >= 3)
+        receiver = exec->argument(2);
+
+    PropertySlot slot(receiver);
+    return JSValue::encode(target.get(exec, propertyName, slot));
+}
+
 // http://www.ecma-international.org/ecma-262/6.0/#sec-reflect.getownpropertydescriptor
 EncodedJSValue JSC_HOST_CALL reflectObjectGetOwnPropertyDescriptor(ExecState* exec)