Ignore:
Timestamp:
Feb 18, 2016, 1:55:40 PM (10 years ago)
Author:
[email protected]
Message:

Follow up fix to Implement Proxy.GetOwnProperty
​https://bugs.webkit.org/show_bug.cgi?id=154314

Reviewed by Filip Pizlo.

Part of the implementation was broken because
of how JSObject::getOwnPropertyDescriptor worked.
I've fixed JSObject::getOwnPropertyDescriptor to
be able to handle ProxyObject.

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::performInternalMethodGetOwnProperty):

  • tests/stress/proxy-get-own-property.js:

(assert):
(assert.let.handler.get getOwnPropertyDescriptor):

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/runtime/ProxyObject.cpp

    r196772 r196775  
    144144    CallType callType;
    145145    JSValue getOwnPropertyDescriptorMethod = handler->getMethod(exec, callData, callType, makeIdentifier(vm, "getOwnPropertyDescriptor"), ASCIILiteral("'getOwnPropertyDescriptor' property of a Proxy's handler should be callable."));
     146    if (exec->hadException())
     147        return false;
    146148    JSObject* target = this->target();
    147149    if (getOwnPropertyDescriptorMethod.isUndefined())
Note: See TracChangeset for help on using the changeset viewer.