Changeset 196785 in webkit for trunk/Source/JavaScriptCore/runtime/ProxyObject.cpp

Timestamp:

Feb 18, 2016, 4:27:15 PM (10 years ago)

Author:

[email protected]

Message:

Proxy's don't properly handle Symbols as PropertyKeys.
​https://bugs.webkit.org/show_bug.cgi?id=154385

Reviewed by Mark Lam and Yusuke Suzuki.

We were converting all PropertyKeys to strings, even when
the PropertyName was a Symbol. In the spec, PropertyKeys are
either a Symbol or a String. We now respect that in Proxy.Get and
Proxy.GetOwnProperty.

• runtime/Completion.cpp:

(JSC::profiledEvaluate):
(JSC::createSymbolForEntryPointModule):
(JSC::identifierToJSValue): Deleted.

• runtime/Identifier.h:

(JSC::parseIndex):

• runtime/IdentifierInlines.h:

(JSC::Identifier::fromString):
(JSC::identifierToJSValue):
(JSC::identifierToSafePublicJSValue):

• runtime/ProxyObject.cpp:

(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):

• tests/es6.yaml:
• tests/stress/proxy-basic.js:

(let.handler.getOwnPropertyDescriptor):

File:

• trunk/Source/JavaScriptCore/runtime/ProxyObject.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/ProxyObject.cpp

@@ -105 +105 @@
     MarkedArgumentBuffer arguments;
     arguments.append(target);
-    arguments.append(jsString(exec, propertyName.uid()));
+    arguments.append(identifierToSafePublicJSValue(vm, Identifier::fromUid(&vm, propertyName.uid())));
     if (exec->hadException())
         return JSValue::encode(jsUndefined());
@@ -152 +152 @@
     MarkedArgumentBuffer arguments;
     arguments.append(target);
-    arguments.append(jsString(exec, propertyName.uid()));
+    arguments.append(identifierToSafePublicJSValue(vm, Identifier::fromUid(&vm, propertyName.uid())));
     if (exec->hadException())
         return false;