Changeset 226405 in webkit for trunk/Source/JavaScriptCore/heap/Heap.h

Timestamp:

Jan 4, 2018, 7:42:06 AM (8 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Create parallel SlotVisitors apriori
​https://bugs.webkit.org/show_bug.cgi?id=180907

Reviewed by Saam Barati.

The number of SlotVisitors are capped with the number of HeapHelperPool's threads + 2.
If we create these SlotVisitors apriori, we do not need to create SlotVisitors dynamically.
Then we do not need to grab locks while iterating all the SlotVisitors.

In addition, we do not need to consider the case that the number of SlotVisitors increases
after setting up VisitCounters in MarkingConstraintSolver since the number of SlotVisitors
does not increase any more.

• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::runBeginPhase):

• heap/Heap.h:
• heap/HeapInlines.h:

(JSC::Heap::forEachSlotVisitor):
(JSC::Heap::numberOfSlotVisitors): Deleted.

• heap/MarkingConstraintSolver.cpp:

(JSC::MarkingConstraintSolver::didVisitSomething const):

File:

• trunk/Source/JavaScriptCore/heap/Heap.h (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/Heap.h

@@ -373 +373 @@
     template<typename Func>
     void forEachSlotVisitor(const Func&);
-    unsigned numberOfSlotVisitors();
 
 private: