Changeset 226407 in webkit for trunk/Source/JavaScriptCore/heap/Heap.h

Timestamp:

Jan 4, 2018, 7:54:40 AM (8 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Remove LocalScope
​https://bugs.webkit.org/show_bug.cgi?id=181206

Reviewed by Geoffrey Garen.

The last user of HandleStack and LocalScope is JSON. But MarkedArgumentBuffer is enough for their use.
This patch changes JSON parsing and stringifying to using MarkedArgumentBuffer. And remove HandleStack
and LocalScope.

We make Stringifier and Walker WTF_FORBID_HEAP_ALLOCATION to place them on the stack. So they can hold
JSObject* directly in their fields.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• heap/HandleStack.cpp: Removed.
• heap/HandleStack.h: Removed.
• heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):

• heap/Heap.h:

(JSC::Heap::handleSet):
(JSC::Heap::handleStack): Deleted.

• heap/Local.h: Removed.
• heap/LocalScope.h: Removed.
• runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::object const):
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::stringify):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::Holder):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::Walker):
(JSC::Walker::callReviver):
(JSC::Walker::walk):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
(JSC::JSONParse):
(JSC::JSONStringify):

File:

• trunk/Source/JavaScriptCore/heap/Heap.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/heap/Heap.h

@@ -31 +31 @@
 #include "GCRequest.h"
 #include "HandleSet.h"
-#include "HandleStack.h"
 #include "HeapFinalizerCallback.h"
 #include "HeapObserver.h"
@@ -239 +238 @@
 
     HandleSet* handleSet() { return &m_handleSet; }
-    HandleStack* handleStack() { return &m_handleStack; }
 
     void willStartIterating();
@@ -606 +604 @@
     
     HandleSet m_handleSet;
-    HandleStack m_handleStack;
     std::unique_ptr<CodeBlockSet> m_codeBlocks;
     std::unique_ptr<JITStubRoutineSet> m_jitStubRoutines;