Changeset 26074 in webkit for trunk/JavaScriptCore/JavaScriptCore.exp

Timestamp:

Oct 5, 2007, 5:54:00 PM (18 years ago)

Author:

ggaren

Message:

JavaScriptCore:

Reviewed by Sam Weinig.

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

• kjs/object.cpp: (KJS::JSObject::removeDirect):
• kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: ​http://bugs.webkit.org/show_bug.cgi?id=15385.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
• bindings/js/kjs_proxy.h:
• page/Frame.cpp: (WebCore::Frame::setDocument):

File:

• trunk/JavaScriptCore/JavaScriptCore.exp (modified) (5 diffs)

trunk/JavaScriptCore/JavaScriptCore.exp

@@ -1 @@
-_jscore_collector_introspection
-_jscore_fastmalloc_introspection
 _JSCheckScriptSyntax
 _JSClassCreate
@@ -143 +141 @@
 __ZN3KJS13SavedBuiltinsC1Ev
 __ZN3KJS13SavedBuiltinsD1Ev
+__ZN3KJS13jsOwnedStringERKNS_7UStringE
 __ZN3KJS14StringInstance14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
 __ZN3KJS14StringInstance16getPropertyNamesEPNS_9ExecStateERNS_17PropertyNameArrayE
@@ -198 +197 @@
 __ZN3KJS8DebuggerD2Ev
 __ZN3KJS8JSObject11hasInstanceEPNS_9ExecStateEPNS_7JSValueE
+__ZN3KJS8JSObject12removeDirectERKNS_10IdentifierE
 __ZN3KJS8JSObject14callAsFunctionEPNS_9ExecStateEPS0_RKNS_4ListE
 __ZN3KJS8JSObject14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
@@ -214 +214 @@
 __ZN3KJS8jsStringEPKc
 __ZN3KJS8jsStringERKNS_7UStringE
-__ZN3KJS13jsOwnedStringERKNS_7UStringE
 __ZN3KJS9Collector15numInterpretersEv
 __ZN3KJS9Collector15recordExtraCostEm
@@ -283 +282 @@
 __ZTVN3KJS19InternalFunctionImpE
 __ZTVN3KJS8JSObjectE
+_jscore_collector_introspection
+_jscore_fastmalloc_introspection
 _kJSClassDefinitionEmpty
 _kjs_pcre_compile