Changeset 26892 in webkit for trunk/JavaScriptCore/JavaScriptCore.exp

Timestamp:

Oct 22, 2007, 11:39:46 AM (18 years ago)

Author:

darin

Message:

Reviewed by Eric Seidel.

• ​http://bugs.webkit.org/show_bug.cgi?id=15617 improve speed of integer conversions

Makes SunSpider 6% faster.

• kjs/JSImmediate.h: Added toInt32 and toUInt32, with separate versions for 32-bit and 64-bit.
• kjs/value.h: (KJS::JSValue::getUInt32): Call JSImmediate::toUInt32.

• kjs/internal.h: Added getInt32.
• kjs/internal.cpp: (KJS::NumberImp::getInt32): Added. (KJS::NumberImp::getUInt32): Replaced with more-optimal implementation stolen from JSValue.

• kjs/value.h: (KJS::jsNumber): Marked ALWAYS_INLINE, because this wasn't getting inlined. (KJS::JSValue::getInt32): Added. (KJS::JSValue::getUInt32): Changed to call the new JSImmediate::toUInt32 to avoid converting from float to double. (KJS::JSValue::toInt32): Made inline, separated out the slow case. (KJS::JSValue::toUInt32): Ditto.
• kjs/value.cpp: (KJS::JSCell::getInt32): Added. (KJS::JSValue::toInt32SlowCase): Renamed from toInt32. Changed to use the new getInt32. Added a faster case for in-range numbers. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Added a faster case for in-range numbers.

• JavaScriptCore.exp: Updated for changes.

File:

• trunk/JavaScriptCore/JavaScriptCore.exp (modified) (2 diffs)

trunk/JavaScriptCore/JavaScriptCore.exp

@@ -243 +243 @@
 __ZNK3KJS4List2atEi
 __ZNK3KJS4List8copyTailEv
+__ZNK3KJS6JSCell8getInt32ERi
 __ZNK3KJS6JSCell9getNumberERd
 __ZNK3KJS6JSCell9getNumberEv
@@ -248 +249 @@
 __ZNK3KJS6JSCell9getStringEv
 __ZNK3KJS6JSCell9getUInt32ERj
+__ZNK3KJS7JSValue15toInt32SlowCaseEPNS_9ExecStateERb
+__ZNK3KJS7JSValue16toUInt32SlowCaseEPNS_9ExecStateERb
 __ZNK3KJS7JSValue7toFloatEPNS_9ExecStateE
-__ZNK3KJS7JSValue7toInt32EPNS_9ExecStateE
-__ZNK3KJS7JSValue7toInt32EPNS_9ExecStateERb
-__ZNK3KJS7JSValue8toUInt32EPNS_9ExecStateE
-__ZNK3KJS7JSValue8toUInt32EPNS_9ExecStateERb
 __ZNK3KJS7JSValue9toIntegerEPNS_9ExecStateE
 __ZNK3KJS7UString10UTF8StringEv