Changeset 262638 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Jun 5, 2020, 12:06:05 PM (5 years ago)

Author:

Devin Rousso

Message:

Logical Assignment: perform NamedEvaluation of anonymous functions
​https://bugs.webkit.org/show_bug.cgi?id=212679

Reviewed by Ross Kirsling.

JSTests:

• stress/logical-assignment-operator-and.js:
• stress/logical-assignment-operator-coalesce.js:
• stress/logical-assignment-operator-or.js:

Source/JavaScriptCore:

• parser/ASTBuilder.h:

(JSC::ASTBuilder::makeAssignNode):

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -1578 +1578 @@
         }
 
-        if (op == Operator::CoalesceEq || op == Operator::OrEq || op == Operator::AndEq)
+        if (op == Operator::CoalesceEq || op == Operator::OrEq || op == Operator::AndEq) {
+            if (expr->isBaseFuncExprNode()) {
+                auto metadata = static_cast<BaseFuncExprNode*>(expr)->metadata();
+                metadata->setEcmaName(resolve->identifier());
+            } else if (expr->isClassExprNode())
+                static_cast<ClassExprNode*>(expr)->setEcmaName(resolve->identifier());
             return new (m_parserArena) ShortCircuitReadModifyResolveNode(location, resolve->identifier(), op, expr, exprHasAssignments, divot, start, end);
+        }
 
         return new (m_parserArena) ReadModifyResolveNode(location, resolve->identifier(), op, expr, exprHasAssignments, divot, start, end);