Changeset 264397 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Jul 15, 2020, 7:47:44 AM (5 years ago)

Author:

Alexey Shvayka

Message:

Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
​https://bugs.webkit.org/show_bug.cgi?id=214325

Reviewed by Darin Adler and Saam Barati.

JSTests:

• microbenchmarks/has-own-property-for-in-loop-reflect-name.js: Added.
• stress/reflect-has.js:
• stress/reflect.js:

Source/JavaScriptCore:

Currently, HasOwnPropertyFunctionCallDotNode is emitted for all ResolveNodes
except ones with "Reflect" identifier. This exception doesn't seem necessary
as ReflectObject inherits ordinary Object.prototype.hasOwnProperty method.

This patch removes the exception, advancing provided "Reflect" microbenchmark
by 20%. No behavior change.

• parser/ASTBuilder.h:

(JSC::ASTBuilder::makeFunctionCallNode):

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -1456 +1456 @@
         && args->m_listNode->m_expr->isResolveNode()
         && !args->m_listNode->m_next
-        && ((dot->base()->isResolveNode() && static_cast<ResolveNode*>(dot->base())->identifier() != m_vm.propertyNames->Reflect) || dot->base()->isThisNode())) {
+        && (dot->base()->isResolveNode() || dot->base()->isThisNode())) {
         // We match the AST pattern:
         // <resolveNode|thisNode>.hasOwnProperty(<resolveNode>)