Changeset 264633 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Jul 20, 2020, 4:28:28 PM (5 years ago)

Author:

Ross Kirsling

Message:

[JSC] eval?.() should be indirect eval
​https://bugs.webkit.org/show_bug.cgi?id=214568

Reviewed by Keith Miller.

JSTests:

• test262/expectations.yaml:

Mark two test cases as passing.

Source/JavaScriptCore:

eval?.() is specified as indirect eval, but (virtually) all implementations assumed it should be direct eval.
I raised this topic in today's TC39 meeting and we've decided to keep the spec as it is.

• parser/ASTBuilder.h:

(JSC::ASTBuilder::makeFunctionCallNode):
Don't use EvalFunctionCallNode for optional call of eval.

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -1428 +1428 @@
         ResolveNode* resolve = static_cast<ResolveNode*>(func);
         const Identifier& identifier = resolve->identifier();
-        if (identifier == m_vm.propertyNames->eval) {
+        if (identifier == m_vm.propertyNames->eval && !isOptionalCall) {
             usesEval();
             return new (m_parserArena) EvalFunctionCallNode(location, args, divot, divotStart, divotEnd);