Changeset 26811 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Oct 20, 2007, 12:11:53 AM (18 years ago)

Author:

ggaren

Message:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15570
Store gathered declaration nodes in the function body node.

This means that you only have to gather the declaration nodes the first
time the function executes. Performance gain of 2.10% on SunSpider,
0.90% on command-line JS iBench.

• kjs/nodes.cpp: Split declaration stack initialization code off into initializeDeclarationStacks(). (FunctionBodyNode::FunctionBodyNode): (FunctionBodyNode::initializeDeclarationStacks): (FunctionBodyNode::processDeclarations):

• kjs/nodes.h: Changed DeclarationStacks structure to hold references, since the actual Vectors are now stored either on the stack or in the function body node.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -2423 +2423 @@
     , m_sourceURL(Lexer::curr()->sourceURL())
     , m_sourceId(Parser::sid)
-{
-
+    , m_initializedDeclarationStacks(false)
+{
   setLoc(-1, -1);
 }
 
-void FunctionBodyNode::processDeclarations(ExecState* exec)
+void FunctionBodyNode::initializeDeclarationStacks()
 {
     Node* node = source.get();
@@ -2434 +2434 @@
         return;
 
-    DeclarationStacks stacks;
-    DeclarationStacks::NodeStack& nodeStack = stacks.nodeStack;
+    DeclarationStacks::NodeStack nodeStack;
+    DeclarationStacks stacks(nodeStack, m_varStack, m_functionStack);
     
     while (true) {
@@ -2448 +2448 @@
         nodeStack.shrink(size);
     }
-    
+
+    m_initializedDeclarationStacks = true;
+}
+
+void FunctionBodyNode::processDeclarations(ExecState* exec)
+{
+    if (!m_initializedDeclarationStacks)
+        initializeDeclarationStacks();
+
     size_t i, size;
 
-    DeclarationStacks::FunctionStack& functionStack = stacks.functionStack;
-    for (i = 0, size = functionStack.size(); i < size; ++i)
-        functionStack[i]->processDeclaration(exec);
-
-    DeclarationStacks::VarStack& varStack = stacks.varStack;
-    for (i = 0, size = varStack.size(); i < size; ++i)
-        varStack[i]->processDeclaration(exec);
+    for (i = 0, size = m_functionStack.size(); i < size; ++i)
+        m_functionStack[i]->processDeclaration(exec);
+
+    for (i = 0, size = m_varStack.size(); i < size; ++i)
+        m_varStack[i]->processDeclaration(exec);
 }