Changeset 26832 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Oct 20, 2007, 3:38:44 PM (18 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=15579 stop churning identifier reference counts copying Completion objects

• kjs/completion.h: Replace the Identifier with an Identifier*.
• kjs/nodes.cpp: (ForInNode::execute): Update for change to Completion constructor. (ContinueNode::execute): Ditto. (BreakNode::execute): Ditto.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1999 +1999 @@
   // property list but will throw an exception if you attempt to
   // access any property.
-  if (e->isUndefinedOrNull()) {
-    return Completion(Normal, 0);
-  }
+  if (e->isUndefinedOrNull())
+    return Completion(Normal);
 
   KJS_CHECKEXCEPTION
@@ -2091 +2090 @@
   if (ident.isEmpty() && !exec->context()->inIteration())
     return createErrorCompletion(exec, SyntaxError, "Invalid continue statement.");
-  else if (!ident.isEmpty() && !exec->context()->seenLabels()->contains(ident))
+  if (!ident.isEmpty() && !exec->context()->seenLabels()->contains(ident))
     return createErrorCompletion(exec, SyntaxError, "Label %s not found.", ident);
-  else
-    return Completion(Continue, 0, ident);
+  return Completion(Continue, &ident);
 }
 
@@ -2107 +2105 @@
       !exec->context()->inSwitch())
     return createErrorCompletion(exec, SyntaxError, "Invalid break statement.");
-  else if (!ident.isEmpty() && !exec->context()->seenLabels()->contains(ident))
+  if (!ident.isEmpty() && !exec->context()->seenLabels()->contains(ident))
     return createErrorCompletion(exec, SyntaxError, "Label %s not found.");
-  else
-    return Completion(Break, 0, ident);
+  return Completion(Break, &ident);
 }