Changeset 2783 in webkit for trunk/JavaScriptCore/kjs/internal.cpp

Timestamp:

Nov 20, 2002, 1:12:14 PM (23 years ago)

Author:

darin

Message:

• decrease ref/deref -- 5% speedup in iBench

• JavaScriptCore.pbproj/project.pbxproj: Added array_instance.h
• kjs/array_instance.h: Added so it can be shared by function.h.

• kjs/array_object.cpp:
• kjs/array_object.h:
• kjs/bool_object.cpp:
• kjs/bool_object.h:
• kjs/collector.cpp:
• kjs/date_object.cpp:
• kjs/date_object.h:
• kjs/error_object.cpp:
• kjs/function.cpp:
• kjs/function.h:
• kjs/function_object.cpp:
• kjs/internal.cpp:
• kjs/internal.h:
• kjs/math_object.cpp:
• kjs/nodes.cpp:
• kjs/number_object.cpp:
• kjs/object.cpp:
• kjs/object.h:
• kjs/object_object.cpp:
• kjs/property_map.cpp:
• kjs/reference.cpp:
• kjs/reference.h:
• kjs/regexp_object.cpp:
• kjs/string_object.cpp:
• kjs/string_object.h:
• kjs/value.cpp:
• kjs/value.h: Switched lots of interfaces so they don't require ref/deref.

File:

• trunk/JavaScriptCore/kjs/internal.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/internal.cpp

@@ -222 +222 @@
 // ------------------------------ NumberImp ------------------------------------
 
+NumberImp *NumberImp::staticNaN;
+
+ValueImp *NumberImp::create(int i)
+{
+    if (SimpleNumber::fits(i))
+        return SimpleNumber::make(i);
+    NumberImp *imp = new NumberImp(static_cast<double>(i));
+    imp->setGcAllowedFast();
+    return imp;
+}
+
+ValueImp *NumberImp::create(double d)
+{
+    if (SimpleNumber::fits(d))
+        return SimpleNumber::make((int)d);
+    if (isNaN(d))
+        return staticNaN;
+    NumberImp *imp = new NumberImp(d);
+    imp->setGcAllowedFast();
+    return imp;
+}
+
 Value NumberImp::toPrimitive(ExecState *, Type) const
 {
@@ -453 +475 @@
   BooleanImp::staticFalse = new BooleanImp(false);
   BooleanImp::staticFalse->ref();
+  NumberImp::staticNaN = new NumberImp(NaN);
+  NumberImp::staticNaN->ref();
 }
 
@@ -470 +494 @@
   BooleanImp::staticFalse->setGcAllowed();
   BooleanImp::staticFalse = 0L;
+  NumberImp::staticNaN->deref();
+  NumberImp::staticNaN->setGcAllowed();
+  NumberImp::staticNaN = 0;
 }
 
@@ -787 +814 @@
 
 InternalFunctionImp::InternalFunctionImp(FunctionPrototypeImp *funcProto)
-  : ObjectImp(Object(funcProto))
+  : ObjectImp(funcProto)
 {
 }