Changeset 2792 in webkit for trunk/JavaScriptCore/kjs/internal.cpp

Timestamp:

Nov 20, 2002, 4:55:08 PM (23 years ago)

Author:

darin

Message:

• created argument list objects only on demand for a 7.5% speedup

• kjs/function.h: Change ActivationImp around.
• kjs/function.cpp: (FunctionImp::call): Pass a pointer to the arguments list to avoid ref/unref. (FunctionImp::get): Get the function pointer from the context directly, not the activation object. (ArgumentsImp::ArgumentsImp): Add an overload that takes no arguments. (ActivationImp::ActivationImp): Store a context pointer and an arguments object pointer. (ActivationImp::get): Special case for arguments, create it and return it. (ActivationImp::put): Special case for arguments, can't be set. (ActivationImp::hasProperty): Special case for arguments, return true. (ActivationImp::deleteProperty): Special case for arguments, refuse to delete. (ActivationImp::mark): Mark the arguments object. (ActivationImp::createArgumentsObject): Do the work of actually creating it. (GlobalFuncImp::call): Use stack-based objects for the ContextImp and ExecState.

• kjs/internal.h: Keep function and arguments pointer in the context.
• kjs/internal.cpp: (ContextImp::ContextImp): Don't pass in the func and args when making an ActivationImp. (InterpreterImp::evaluate): Use stack-based objects here.

• kjs/types.h: Add ArgumentList as a synonym for List, soon to be separate.

File:

• trunk/JavaScriptCore/kjs/internal.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/internal.cpp

@@ -356 +356 @@
 // ------------------------------ ContextImp -----------------------------------
 
-
 // ECMA 10.2
 ContextImp::ContextImp(Object &glob, ExecState *exec, Object &thisV, CodeType type,
-                       ContextImp *_callingContext, FunctionImp *func, const List &args)
+                       ContextImp *_callingContext, FunctionImp *func, const ArgumentList *args)
+    : _function(func), _arguments(args)
 {
   codeType = type;
@@ -366 +366 @@
   // create and initialize activation object (ECMA 10.1.6)
   if (type == FunctionCode || type == AnonymousCode ) {
-    activation = Object(new ActivationImp(exec,func,args));
+    activation = Object(new ActivationImp(exec));
     variable = activation;
   } else {
@@ -782 +782 @@
   else {
     // execute the code
-    ExecState *exec1 = 0;
-    ContextImp *ctx = new ContextImp(globalObj, exec1, thisObj);
-    ExecState *newExec = new ExecState(m_interpreter,ctx);
-
-    res = progNode->execute(newExec);
-
-    delete newExec;
-    delete ctx;
+    ContextImp ctx(globalObj, 0, thisObj);
+    ExecState newExec(m_interpreter,&ctx);
+    res = progNode->execute(&newExec);
   }