Changeset 279448 in webkit for trunk/Source/JavaScriptCore/parser/Parser.h

Timestamp:

Jun 30, 2021, 7:12:20 PM (4 years ago)

Author:

[email protected]

Message:

[JSC] Stop generating default parameter code if class constructor is called without 'new'
​https://bugs.webkit.org/show_bug.cgi?id=227547
rdar://78821453

Reviewed by Mark Lam.

JSTests:

• stress/calling-non-callable-constructors.js: Added.

(shouldThrow):

Source/JavaScriptCore:

We already do not generate body bytecode when class constructor is called without 'new' because many features including "super()" assume
that they generate bytecode only when it is called as a constructor. But we are not doing that for default parameters' bytecode generation.
This patch stops generating bytecode for default parameters if class constructor is called without 'new'.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):

• runtime/ConstructorKind.h:

File:

• trunk/Source/JavaScriptCore/parser/Parser.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Parser.h

@@ -623 +623 @@
 
     bool hasDirectSuper() const { return m_hasDirectSuper; }
-    bool setHasDirectSuper() { return std::exchange(m_hasDirectSuper, true); }
+    void setHasDirectSuper() { m_hasDirectSuper = true; }
 
     bool needsSuperBinding() const { return m_needsSuperBinding; }
-    bool setNeedsSuperBinding() { return std::exchange(m_needsSuperBinding, true); }
+    void setNeedsSuperBinding() { m_needsSuperBinding = true; }
     
     void setEvalContextType(EvalContextType evalContextType) { m_evalContextType = evalContextType; }