Changeset 286816 in webkit for trunk/Source/JavaScriptCore/parser/Parser.h

Timestamp:

Dec 9, 2021, 4:25:12 PM (3 years ago)

Author:

[email protected]

Message:

Prepare for transition to C++20
​https://bugs.webkit.org/show_bug.cgi?id=234022

Reviewed by Yusuke Suzuki.

Source/bmalloc:

• bmalloc/List.h:

(bmalloc::List::iterator::operator!= const):
(bmalloc::List::iterator::operator!=): Deleted.

Source/JavaScriptCore:

• bytecode/SuperSampler.cpp:
• bytecode/SuperSampler.h:
• heap/GCSegmentedArray.h:

(JSC::GCSegmentedArrayIterator::operator== const):
(JSC::GCSegmentedArrayIterator::operator!= const):
(JSC::GCSegmentedArrayIterator::operator==): Deleted.
(JSC::GCSegmentedArrayIterator::operator!=): Deleted.

• jit/RegisterSet.h:

(JSC::RegisterSet::iterator::operator== const):
(JSC::RegisterSet::iterator::operator!= const):
(JSC::RegisterSet::iterator::operator==): Deleted.
(JSC::RegisterSet::iterator::operator!=): Deleted.

• parser/Parser.h:

(JSC::ScopeRef::operator== const):
(JSC::ScopeRef::operator!= const):
(JSC::ScopeRef::operator==): Deleted.
(JSC::ScopeRef::operator!=): Deleted.

• parser/ParserTokens.h:
• runtime/GenericOffset.h:

(JSC::GenericOffset::operator== const):
(JSC::GenericOffset::operator!= const):
(JSC::GenericOffset::operator< const):
(JSC::GenericOffset::operator> const):
(JSC::GenericOffset::operator<= const):
(JSC::GenericOffset::operator>= const):

• runtime/PropertyTable.h:

Source/ThirdParty/libwebrtc:

• Source/webrtc/common_audio/wav_header.cc:
• Source/webrtc/modules/audio_processing/include/aec_dump.cc:
• Source/webrtc/modules/audio_processing/include/aec_dump.h:
• Source/webrtc/modules/audio_processing/utility/delay_estimator_wrapper.cc:
• Source/webrtc/modules/audio_processing/vad/vad_audio_proc.h:
• Source/webrtc/modules/video_coding/media_opt_util.h:
• Source/webrtc/rtc_base/race_checker.h:
• Source/webrtc/rtc_base/units/unit_base.h:

(webrtc::rtc_units_impl::UnitBase::operator== const):
(webrtc::rtc_units_impl::UnitBase::operator!= const):
(webrtc::rtc_units_impl::UnitBase::operator<= const):
(webrtc::rtc_units_impl::UnitBase::operator>= const):
(webrtc::rtc_units_impl::UnitBase::operator> const):
(webrtc::rtc_units_impl::UnitBase::operator< const):

Source/WebCore:

• contentextensions/ContentExtensionActions.h:

(WebCore::ContentExtensions::ActionWithoutMetadata::operator== const):
(WebCore::ContentExtensions::ActionWithStringMetadata::operator== const):

• contentextensions/ImmutableNFANodeBuilder.h:

(WebCore::ContentExtensions::ImmutableNFANodeBuilder::FakeRangeIterator::operator== const):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::FakeRangeIterator::operator!= const):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::FakeRangeIterator::operator==): Deleted.
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::FakeRangeIterator::operator!=): Deleted.

• loader/cache/CachedResourceHandle.h:

(WebCore::CachedResourceHandle::operator== const):

• page/mac/ImageOverlayControllerMac.mm:

(WebCore::ImageOverlayController::updateDataDetectorHighlights):

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
(WebCore::ServicesOverlayController::buildSelectionHighlight):

• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::getAudioStreamBasicDescription):

• platform/audio/cocoa/AudioFileReaderCocoa.cpp:

(WebCore::AudioFileReader::clientDataFormat const):

• platform/audio/cocoa/CAAudioStreamDescription.cpp:

(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):

• platform/audio/cocoa/CAAudioStreamDescription.h:
• platform/audio/ios/AudioOutputUnitAdaptorIOS.cpp:

(WebCore::AudioOutputUnitAdaptor::configure):

• platform/audio/mac/AudioOutputUnitAdaptorMac.cpp:

(WebCore::AudioOutputUnitAdaptor::configure):

• platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForDisplayID):

• platform/graphics/DisplayRefreshMonitorManager.h:
• platform/graphics/FontSelectionAlgorithm.h:
• platform/graphics/GraphicsContext.cpp:

(WebCore::TextBoxIterator::operator== const):
(WebCore::TextBoxIterator::operator!= const):
(WebCore::TextBoxIterator::operator==): Deleted.
(WebCore::TextBoxIterator::operator!=): Deleted.

• platform/graphics/PixelBufferConversion.cpp:

(WebCore::makeVImageCGImageFormat):

• platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGLImageExtractor::extractImage):

• platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::createBitmapImageAfterScalingIfNeeded):
(WebCore::ImageBufferCGBackend::copyCGImageForEncoding const):

• platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::create):
(WebCore::ImageBufferCGBitmapBackend::copyNativeImage const):

• platform/graphics/cg/ImageBufferUtilitiesCG.cpp:

(WebCore::encode):

• platform/graphics/cg/NativeImageCG.cpp:

(WebCore::NativeImage::singlePixelSolidColor const):

• platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::ensurePlatformContext):

• platform/graphics/cv/PixelBufferConformerCV.cpp:

(WebCore::PixelBufferConformerCV::createImageFromPixelBuffer):

• platform/graphics/displaylists/DisplayListIterator.h:

(WebCore::DisplayList::DisplayList::Iterator::operator== const):
(WebCore::DisplayList::DisplayList::Iterator::operator!= const):
(WebCore::DisplayList::DisplayList::Iterator::operator==): Deleted.
(WebCore::DisplayList::DisplayList::Iterator::operator!=): Deleted.

• platform/graphics/filters/FEComponentTransfer.h:
• platform/graphics/transforms/Matrix3DTransformOperation.h:
• platform/graphics/transforms/MatrixTransformOperation.h:
• platform/graphics/transforms/PerspectiveTransformOperation.h:
• platform/graphics/transforms/RotateTransformOperation.h:
• platform/graphics/transforms/ScaleTransformOperation.h:
• platform/graphics/transforms/SkewTransformOperation.h:
• platform/graphics/transforms/TranslateTransformOperation.h:
• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::mapPlatformError):

• rendering/GapRects.h:

(WebCore::GapRects::operator== const):
(WebCore::GapRects::operator!= const):
(WebCore::GapRects::operator==): Deleted.
(WebCore::GapRects::operator!=): Deleted.

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setShouldMockBoldSystemFontForAccessibility):

Source/WebKit:

• Shared/mac/MediaFormatReader/MediaFormatReader.cpp:

(WebKit::MediaFormatReader::didParseTracks):

• Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:

(WebKit::MediaSampleCursor::getSampleMap const):

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setRequiresPageVisibilityToPlayAudio:]):

• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration setRequiresSecureHTTPSProxyConnection:]):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

(WebKit::WebsiteDataStoreConfiguration::setRequiresSecureHTTPSProxyConnection):

Source/WTF:

In C++20, volitile is deprecated, operator== is stricter (related to the introduction of operator <=>),
and operations on enums of different types are stricter too. This does the changes we can do before
the transition, which will be done in bug 233963.

• wtf/DateMath.h:

(WTF::LocalTimeOffset::operator== const):
(WTF::LocalTimeOffset::operator!= const):
(WTF::LocalTimeOffset::operator==): Deleted.
(WTF::LocalTimeOffset::operator!=): Deleted.

• wtf/FastBitVector.h:

(WTF::FastBitVectorImpl::operator== const):
(WTF::FastBitVectorImpl::operator!= const):

• wtf/GenericTimeMixin.h:

(WTF::GenericTimeMixin::operator== const):
(WTF::GenericTimeMixin::operator!= const):
(WTF::GenericTimeMixin::operator< const):
(WTF::GenericTimeMixin::operator> const):
(WTF::GenericTimeMixin::operator<= const):
(WTF::GenericTimeMixin::operator>= const):

• wtf/IteratorAdaptors.h:

(WTF::FilterIterator::operator== const):
(WTF::FilterIterator::operator!= const):
(WTF::TransformIterator::operator== const):
(WTF::TransformIterator::operator!= const):

• wtf/Liveness.h:

(WTF::Liveness::LocalCalc::Iterable::iterator::operator== const):
(WTF::Liveness::LocalCalc::Iterable::iterator::operator!= const):
(WTF::Liveness::LocalCalc::Iterable::iterator::operator==): Deleted.
(WTF::Liveness::LocalCalc::Iterable::iterator::operator!=): Deleted.

Tools:

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(createBitmapContext):

• TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestPDFDocument.mm:

(TestWebKitAPI::TestPDFPage::colorAtPoint const):

• WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromCGImage):

File:

• trunk/Source/JavaScriptCore/parser/Parser.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/Parser.h

@@ -951 +951 @@
     }
 
-    bool operator==(const ScopeRef& other)
+    bool operator==(const ScopeRef& other) const
     {
         ASSERT(other.m_scopeStack == m_scopeStack);
@@ -957 +957 @@
     }
 
-    bool operator!=(const ScopeRef& other)
+    bool operator!=(const ScopeRef& other) const
     {
         return !(*this == other);