Changeset 291215 in webkit for trunk/Source/WebCore/rendering/RenderLineBreak.cpp

Timestamp:

Mar 12, 2022, 8:55:53 PM (3 years ago)

Author:

Alan Bujtas

Message:

[IFC][Integration] Add InlineIterator::Line::selectionPhysicalRect
​https://bugs.webkit.org/show_bug.cgi?id=237796

Reviewed by Antti Koivisto.

Introduce selectionPhysicalRect() so that the clients don't need to convert/flip the logical coords and
also rename selectionRect() to selectionLogicalRect() to clear up any ambiguity.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):

• layout/integration/InlineIteratorLine.h:

(WebCore::InlineIterator::Line::selectionLogicalRect const):
(WebCore::InlineIterator::Line::selectionPhysicalRect const):
(WebCore::InlineIterator::Line::selectionRect const): Deleted.

• rendering/CaretRectComputation.cpp:

(WebCore::computeCaretRectForLinePosition):

File:

• trunk/Source/WebCore/rendering/RenderLineBreak.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderLineBreak.cpp

@@ -188 +188 @@
     auto line = run->line();
 
-    auto lineSelectionRect = line->selectionRect();
+    auto lineSelectionRect = line->selectionLogicalRect();
     LayoutRect rect = IntRect(run->logicalLeft(), lineSelectionRect.y(), 0, lineSelectionRect.height());
     if (!line->isHorizontal())