Changeset 291312 in webkit for trunk/Source/WebCore/rendering/RenderLineBreak.cpp

Timestamp:

Mar 15, 2022, 2:17:33 PM (3 years ago)

Author:

Alan Bujtas

Message:

[IFC][Integration] Rename selection* to enclosing* in InlineIterator::Line
​https://bugs.webkit.org/show_bug.cgi?id=237909

Reviewed by Antti Koivisto.

These functions return enclosing (line box and content) geometries which we happen to use to compute selection boundaries (among other things).

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):

• layout/integration/InlineIteratorLine.cpp:

(WebCore::InlineIterator::Line::blockDirectionPointInLine const):
(WebCore::InlineIterator::Line::enclosingTopAdjustedForPrecedingBlock const):
(WebCore::InlineIterator::Line::enclosingHeightAdjustedForPrecedingBlock const):
(WebCore::InlineIterator::Line::selectionTopAdjustedForPrecedingBlock const): Deleted.
(WebCore::InlineIterator::Line::selectionHeightAdjustedForPrecedingBlock const): Deleted.

• layout/integration/InlineIteratorLine.h:

(WebCore::InlineIterator::Line::enclosingTop const):
(WebCore::InlineIterator::Line::enclosingTopForHitTesting const):
(WebCore::InlineIterator::Line::enclosingBottom const):
(WebCore::InlineIterator::Line::enclosingHeight const):
(WebCore::InlineIterator::Line::enclosingLogicalRect const):
(WebCore::InlineIterator::Line::enclosingPhysicalRect const):
(WebCore::InlineIterator::Line::selectionTop const): Deleted.
(WebCore::InlineIterator::Line::selectionTopForHitTesting const): Deleted.
(WebCore::InlineIterator::Line::selectionBottom const): Deleted.
(WebCore::InlineIterator::Line::selectionHeight const): Deleted.
(WebCore::InlineIterator::Line::selectionLogicalRect const): Deleted.
(WebCore::InlineIterator::Line::selectionPhysicalRect const): Deleted.

• layout/integration/InlineIteratorTextBox.cpp:

(WebCore::InlineIterator::TextBox::selectionRect const):

• rendering/CaretRectComputation.cpp:

(WebCore::computeCaretRectForLinePosition):

• rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::selectionTopAdjustedForPrecedingBlock const):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustEnclosingTopForPrecedingBlock const):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::adjustSelectionTopForPrecedingBlock const): Deleted.

• rendering/RenderBlockFlow.h:
• rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionGeometries):

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::collectSelectionGeometries):

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

• rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

• rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::paintBackground):

File:

• trunk/Source/WebCore/rendering/RenderLineBreak.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderLineBreak.cpp

@@ -188 +188 @@
     auto line = run->line();
 
-    auto lineSelectionRect = line->selectionLogicalRect();
+    auto lineSelectionRect = line->enclosingLogicalRect();
     LayoutRect rect = IntRect(run->logicalLeft(), lineSelectionRect.y(), 0, lineSelectionRect.height());
     if (!line->isHorizontal())