Changeset 291463 in webkit for trunk/Source/WebCore/rendering/RenderLineBreak.cpp

Timestamp:

Mar 17, 2022, 7:30:52 PM (3 years ago)

Author:

Alan Bujtas

Message:

[IFC][Integration] Introduce LineSelection
​https://bugs.webkit.org/show_bug.cgi?id=237997

Reviewed by Antti Koivisto.

Use LineSelection to retrieve line based selection information.
This is in preparation for removing selection/hittesting related functions from InlineIterator::Line.

• WebCore.xcodeproj/project.pbxproj:
• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):

• layout/integration/InlineIteratorLine.h:
• layout/integration/InlineIteratorTextBox.cpp:

(WebCore::InlineIterator::TextBox::selectionRect const):

• layout/integration/LineSelection.h: Added.

(WebCore::LineSelection::logicalTop):
(WebCore::LineSelection::logicalBottom):
(WebCore::LineSelection::logicalRect):
(WebCore::LineSelection::physicalRect):
(WebCore::LineSelection::logicalTopAdjustedForPrecedingBlock):
(WebCore::LineSelection::logicalHeightAdjustedForPrecedingBlock):
(WebCore::LineSelection::selectionState):

• rendering/CaretRectComputation.cpp:

(WebCore::computeCaretRectForLinePosition):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustEnclosingTopForPrecedingBlock const):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionGeometries):

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::collectSelectionGeometries):

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

• rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

• rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::paintBackground):

File:

• trunk/Source/WebCore/rendering/RenderLineBreak.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderLineBreak.cpp

@@ -32 +32 @@
 #include "LegacyInlineElementBox.h"
 #include "LegacyRootInlineBox.h"
+#include "LineSelection.h"
 #include "LogicalSelectionOffsetCaches.h"
 #include "RenderBlock.h"
@@ -188 +189 @@
     auto line = run->line();
 
-    auto lineSelectionRect = line->enclosingLogicalRect();
+    auto lineSelectionRect = LineSelection::logicalRect(*line);
     LayoutRect rect = IntRect(run->logicalLeft(), lineSelectionRect.y(), 0, lineSelectionRect.height());
     if (!line->isHorizontal())