Changeset 33382 in webkit for trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp

Timestamp:

May 13, 2008, 12:35:31 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-13 Kevin McCullough <​[email protected]>

Reviewed by Sam.

<rdar://problem/5770054> JavaScript profiler (10928)

• Made some functions static (as per Adam) and changed from using raw pointers to RefPtr for making these JavaScript Objects.

• profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::addChild): (KJS::FunctionCallProfile::findChild):
• profiler/FunctionCallProfile.h: (KJS::FunctionCallProfile::create):
• profiler/Profile.cpp: (KJS::Profile::Profile): (KJS::Profile::willExecute): (KJS::Profile::didExecute): (KJS::functionNameCountPairComparator):
• profiler/Profile.h: (KJS::Profile::create): (KJS::Profile::title): (KJS::Profile::callTree):
• profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
• profiler/Profiler.h: (KJS::Profiler::allProfiles): (KJS::Profiler::clearProfiles):

File:

• trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp (modified) (3 diffs)

trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp

@@ -45 +45 @@
 }
 
-FunctionCallProfile::~FunctionCallProfile()
-{
-    deleteAllValues(m_children);
-}
-
-
 void FunctionCallProfile::willExecute()
 {
@@ -72 +66 @@
 }
 
-void FunctionCallProfile::addChild(FunctionCallProfile* child)
+void FunctionCallProfile::addChild(RefPtr<FunctionCallProfile>& child)
 {
     if (!child)
@@ -89 +83 @@
     for (StackIterator currentChild = m_children.begin(); currentChild != m_children.end(); ++currentChild) {
         if ((*currentChild)->functionName() == name)
-            return *currentChild;
+            return (*currentChild).get();
     }