Changeset 33388 in webkit for trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp

Timestamp:

May 13, 2008, 2:18:02 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-13 Kevin McCullough <​[email protected]>

Reviewed by Geoff.

<rdar://problem/5770054> JavaScript profiler (10928)
Use PassRefPtrs instead of RefPtrs when appropriate.

• profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::addChild):
• profiler/FunctionCallProfile.h:
• profiler/Profile.h: (KJS::Profile::callTree):

File:

• trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp (modified) (2 diffs)

trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp

@@ -66 +66 @@
 }
 
-void FunctionCallProfile::addChild(RefPtr<FunctionCallProfile>& child)
+void FunctionCallProfile::addChild(PassRefPtr<FunctionCallProfile> prpChild)
 {
-    if (!child)
-        return;
+    ASSERT(prpChild);
 
+    RefPtr<FunctionCallProfile> child = prpChild;
     for (StackIterator currentChild = m_children.begin(); currentChild != m_children.end(); ++currentChild) {
         if ((*currentChild)->functionName() == child->functionName())
@@ -76 +76 @@
     }
 
-    m_children.append(child);
+    m_children.append(child.release());
 }