Changeset 35226 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Jul 17, 2008, 1:39:52 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-07-17 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Fixed <rdar://problem/6081636> Functions calls use more temporary
registers than necessary

Holding a reference to the last statement result register caused each
successive statement to output its result to an even higher register.

Happily, statements don't actually need to return a result register
at all. I hope to make this clearer in a future cleanup patch,
but this change will fix the major bug for now.

• kjs/nodes.cpp: (KJS::statementListEmitCode):

LayoutTests:

2008-07-17 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Test for <rdar://problem/6081636> Functions calls use more temporary
registers than necessary

• fast/js/function-call-register-allocation.html: Added.
• fast/js/function-call-register-allocation-expected.txt: Added.
• fast/js/resources/function-call-register-allocation.js: Added.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -990 +990 @@
 static inline RegisterID* statementListEmitCode(StatementVector& statements, CodeGenerator& generator, RegisterID* dst = 0)
 {
-    RefPtr<RegisterID> r0 = dst;
-
     StatementVector::iterator end = statements.end();
     for (StatementVector::iterator it = statements.begin(); it != end; ++it) {
         StatementNode* n = it->get();
         generator.emitDebugHook(WillExecuteStatement, n->firstLine(), n->lastLine());
-        if (RegisterID* r1 = generator.emitNode(dst, n))
-            r0 = r1;
-    }
-    
-    return r0.get();
+        generator.emitNode(dst, n);
+    }
+    return 0;
 }