Changeset 35230 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Jul 17, 2008, 4:53:39 PM (17 years ago)

Author:

[email protected]

Message:

2008-07-17 Geoffrey Garen <​[email protected]>

Reviewed by John Sullivan and Oliver Hunt.

A tiny bit of tidying in function call register allocation.

This patch saves one register when invoking a function expression and/or
a new expression that is stored in a temporary.

Since it's just one register, I can't make a testcase for it.

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall): No need to ref the function we're calling or its base. We'd like the call frame to overlap with them, if possible. op_call will read the function and its base before writing the call frame, so this is safe.

• kjs/nodes.cpp: (KJS::NewExprNode::emitCode): No need to ref the function we're new-ing, for the same reasons stated above.

(KJS::FunctionCallValueNode::emitCode): ditto

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -400 +400 @@
 RegisterID* NewExprNode::emitCode(CodeGenerator& generator, RegisterID* dst)
 {
-    RefPtr<RegisterID> r0 = generator.emitNode(m_expr.get());
-    return generator.emitConstruct(generator.finalDestination(dst), r0.get(), m_args.get());
+    RegisterID* r0 = generator.emitNode(m_expr.get());
+    return generator.emitConstruct(generator.finalDestination(dst), r0, m_args.get());
 }
 
@@ -414 +414 @@
 RegisterID* FunctionCallValueNode::emitCode(CodeGenerator& generator, RegisterID* dst)
 {
-    RefPtr<RegisterID> func = generator.emitNode(m_expr.get());
-    return generator.emitCall(generator.finalDestination(dst), func.get(), 0, m_args.get());
+    RegisterID* func = generator.emitNode(m_expr.get());
+    return generator.emitCall(generator.finalDestination(dst), func, 0, m_args.get());
 }