Changeset 36408 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Sep 14, 2008, 4:01:03 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Cameron Zwarich <​[email protected]>

Reviewed by Oliver Hunt.

Bug 20816: op_lesseq should be optimized
<​https://bugs.webkit.org/show_bug.cgi?id=20816>

Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.

This is a 9.4% speedup on the V8 Crypto benchmark.

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue):
• VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_lesseq):
• VM/Machine.h:
• VM/Opcode.h:

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -571 +571 @@
             break;
         }
+        case op_loop_if_lesseq: {
+            emitSlowScriptCheck(i);
+
+            unsigned target = instruction[i + 3].u.operand;
+            JSValue* src2imm = getConstantImmediateNumericArg(instruction[i + 2].u.operand);
+            if (src2imm) {
+                emitGetArg(instruction[i + 1].u.operand, X86::edx);
+                emitJumpSlowCaseIfNotImm(X86::edx, i);
+                m_jit.cmpl_i32r(reinterpret_cast<unsigned>(src2imm), X86::edx);
+                m_jmpTable.append(JmpTable(m_jit.emitUnlinkedJle(), i + 3 + target));
+            } else {
+                emitGetArg(instruction[i + 1].u.operand, X86::eax);
+                emitGetArg(instruction[i + 2].u.operand, X86::edx);
+                emitJumpSlowCaseIfNotImm(X86::eax, i);
+                emitJumpSlowCaseIfNotImm(X86::edx, i);
+                m_jit.cmpl_rr(X86::edx, X86::eax);
+                m_jmpTable.append(JmpTable(m_jit.emitUnlinkedJle(), i + 3 + target));
+            }
+            i += 4;
+            break;
+        }
         case op_new_object: {
             emitCall(i, Machine::cti_op_new_object);
@@ -1446 +1467 @@
             break;
         }
+        case op_loop_if_lesseq: {
+            emitSlowScriptCheck(i);
+
+            unsigned target = instruction[i + 3].u.operand;
+            JSValue* src2imm = getConstantImmediateNumericArg(instruction[i + 2].u.operand);
+            if (src2imm) {
+                m_jit.link(iter->from, m_jit.label());
+                emitPutArg(X86::edx, 0);
+                emitGetPutArg(instruction[i + 2].u.operand, 4, X86::ecx);
+                emitCall(i, Machine::cti_op_loop_if_lesseq);
+                m_jit.testl_rr(X86::eax, X86::eax);
+                m_jit.link(m_jit.emitUnlinkedJne(), m_labels[i + 3 + target]);
+            } else {
+                m_jit.link(iter->from, m_jit.label());
+                m_jit.link((++iter)->from, m_jit.label());
+                emitPutArg(X86::eax, 0);
+                emitPutArg(X86::edx, 4);
+                emitCall(i, Machine::cti_op_loop_if_lesseq);
+                m_jit.testl_rr(X86::eax, X86::eax);
+                m_jit.link(m_jit.emitUnlinkedJne(), m_labels[i + 3 + target]);
+            }
+            i += 4;
+            break;
+        }
         case op_pre_inc: {
             unsigned srcDst = instruction[i + 1].u.operand;