Changeset 36412 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Sep 14, 2008, 5:26:08 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Cameron Zwarich <​[email protected]>

Reviewed by Maciej Stachowiak.

Bug 20827: the 'typeof' operator is slow
<​https://bugs.webkit.org/show_bug.cgi?id=20827>

Optimize the 'typeof' operator when its result is compared to a constant
string.

This is a 5.5% speedup on the V8 Earley-Boyer test.

JavaScriptCore:

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
• VM/CodeGenerator.h:
• VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
• VM/Machine.h:
• VM/Opcode.h:
• kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
• kjs/nodes.h:

LayoutTests:

• fast/js/resources/typeof-codegen-crash.js: Added.
• fast/js/typeof-codegen-crash-expected.txt: Added.
• fast/js/typeof-codegen-crash.html: Added.

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -375 +375 @@
     }
 
+#define CTI_COMPILE_UNARY_OP(name) \
+    case name: { \
+        emitGetPutArg(instruction[i + 2].u.operand, 0, X86::ecx); \
+        emitCall(i, Machine::cti_##name); \
+        emitPutResult(instruction[i + 1].u.operand); \
+        i += 3; \
+        break; \
+    }
+
 #if ENABLE(SAMPLING_TOOL)
 OpcodeID currentOpcodeID = static_cast<OpcodeID>(-1);
@@ -1151 +1160 @@
             break;
         }
-        case op_typeof: {
-            emitGetPutArg(instruction[i + 2].u.operand, 0, X86::ecx);
-            emitCall(i, Machine::cti_op_typeof);
-            emitPutResult(instruction[i + 1].u.operand);
-            i += 3;
-            break;
-        }
+        CTI_COMPILE_UNARY_OP(op_typeof)
+        CTI_COMPILE_UNARY_OP(op_is_undefined)
+        CTI_COMPILE_UNARY_OP(op_is_boolean)
+        CTI_COMPILE_UNARY_OP(op_is_number)
+        CTI_COMPILE_UNARY_OP(op_is_string)
+        CTI_COMPILE_UNARY_OP(op_is_object)
+        CTI_COMPILE_UNARY_OP(op_is_function)
         CTI_COMPILE_BINARY_OP(op_stricteq)
         CTI_COMPILE_BINARY_OP(op_nstricteq)