Changeset 36427 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Sep 14, 2008, 11:26:15 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up JS construction by extracting "prototype" lookup so PIC applies.

~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.

• VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
• VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -1101 +1101 @@
     // is safe.
 
+    RefPtr<RegisterID> protectFunc = func;
+
+    // Reserve space for prototype
+    RefPtr<RegisterID> funcProto = newTemporary();
+
     // Reserve space for call frame.
     Vector<RefPtr<RegisterID>, RegisterFile::CallFrameHeaderSize> callFrame;
@@ -1114 +1119 @@
     }
 
+    emitGetById(funcProto.get(), func, globalExec()->propertyNames().prototype);
+
     emitOpcode(op_construct);
     instructions().append(dst->index());
     instructions().append(func->index());
+    instructions().append(funcProto->index());
     instructions().append(argv.size() ? argv[0]->index() : m_temporaries.size()); // argv
     instructions().append(argv.size()); // argc