Changeset 36463 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Sep 15, 2008, 4:37:31 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-15 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Removed the CalledAsConstructor flag from the call frame header. Now,
we use an explicit opcode at the call site to fix up constructor results.

SunSpider says 0.4% faster.

cti_op_construct_verify is an out-of-line function call for now, but we
can fix that once StructureID holds type information like isObject.

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Codegen for the new opcode.

• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):

• VM/CodeGenerator.cpp: Codegen for the new opcode. Also... (JSC::CodeGenerator::emitCall): ... don't test for known non-zero value. (JSC::CodeGenerator::emitConstruct): ... ditto.

• VM/Machine.cpp: No more CalledAsConstructor (JSC::Machine::privateExecute): Implementation for the new opcode. (JSC::Machine::cti_op_ret): The speedup: no need to check whether we were called as a constructor. (JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
• VM/Machine.h:

• VM/Opcode.h: Declare new opcode.

• VM/RegisterFile.h: (JSC::RegisterFile::): No more CalledAsConstructor

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -1081 +1081 @@
     instructions().append(func->index());
     instructions().append(base ? base->index() : missingThisObjectMarker()); // We encode the "this" value in the instruction stream, to avoid an explicit instruction for copying or loading it.
-    instructions().append(argv.size() ? argv[0]->index() : m_temporaries.size()); // argv
+    instructions().append(argv[0]->index()); // argv
     instructions().append(argv.size()); // argc
     return dst;
@@ -1125 +1125 @@
     instructions().append(func->index());
     instructions().append(funcProto->index());
-    instructions().append(argv.size() ? argv[0]->index() : m_temporaries.size()); // argv
+    instructions().append(argv[0]->index()); // argv
     instructions().append(argv.size()); // argc
+    
+    emitOpcode(op_construct_verify);
+    instructions().append(dst->index());
+    instructions().append(argv[0]->index());
+
     return dst;
 }