Changeset 54789 in webkit for trunk/JavaScriptCore/runtime/UStringImpl.cpp

Timestamp:

Feb 15, 2010, 1:03:45 PM (15 years ago)

Author:

[email protected]

Message:

Bug 34952 - String lengths in UString should be unsigned.
This matches WebCore::StringImpl, and better unifies behaviour throughout JSC.

Reviewed by Geoff Garen.

JavaScriptCore:

• JavaScriptCore.exp:
• bytecode/EvalCodeCache.h:
• runtime/Identifier.cpp:

(JSC::Identifier::equal):

• runtime/Identifier.h:
• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEscape):

• runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::indent):

• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

• runtime/RegExp.cpp:

(JSC::RegExp::match):

• runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSplit):
(JSC::trimString):

• runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::getCString):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toStrictUInt32):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator<):
(JSC::operator>):
(JSC::compare):
(JSC::equal):
(JSC::UString::UTF8String):

• runtime/UString.h:

(JSC::UString::size):
(JSC::operator==):

• runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

• runtime/UStringImpl.h:

(JSC::UStringImpl::create):
(JSC::UStringImpl::size):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::UStringImpl):

WebCore:

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):

File:

• trunk/JavaScriptCore/runtime/UStringImpl.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/UStringImpl.cpp

@@ -51 +51 @@
 }
 
-PassRefPtr<UStringImpl> UStringImpl::create(const char* c, int length)
+PassRefPtr<UStringImpl> UStringImpl::create(const char* c, unsigned length)
 {
     ASSERT(c);
@@ -60 +60 @@
     UChar* d;
     PassRefPtr<UStringImpl> result = UStringImpl::createUninitialized(length, d);
-    for (int i = 0; i < length; i++)
+    for (unsigned i = 0; i < length; i++)
         d[i] = static_cast<unsigned char>(c[i]); // use unsigned char to zero-extend instead of sign-extend
     return result;
 }
 
-PassRefPtr<UStringImpl> UStringImpl::create(const UChar* buffer, int length)
+PassRefPtr<UStringImpl> UStringImpl::create(const UChar* buffer, unsigned length)
 {
     UChar* newBuffer;