Changeset 60585 in webkit for trunk/JavaScriptCore/qt/api/qscriptvalue.cpp

Timestamp:

Jun 2, 2010, 6:19:59 PM (15 years ago)

Author:

[email protected]

Message:

2010-06-02 Jedrzej Nowacki <​[email protected]>

Reviewed by Kenneth Rohde Christiansen.

Fix the QScriptValue::strictlyEquals function.

Handling for a few edge cases was added.

New autotest that covers the QScriptValue::strictlyEquals function.

[Qt] QScriptValue::strictlyEquals is broken
​https://bugs.webkit.org/show_bug.cgi?id=36600

• qt/api/qscriptvalue.cpp: (QScriptValue::strictlyEquals):
• qt/api/qscriptvalue_p.h: (QScriptValuePrivate::strictlyEquals):
• qt/tests/qscriptvalue/qscriptvalue.pro:
• qt/tests/qscriptvalue/tst_qscriptvalue.h:
• qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Added. (tst_QScriptValue::strictlyEquals_initData): (tst_QScriptValue::strictlyEquals_makeData): (tst_QScriptValue::strictlyEquals_test):

File:

• trunk/JavaScriptCore/qt/api/qscriptvalue.cpp (modified) (1 diff)

trunk/JavaScriptCore/qt/api/qscriptvalue.cpp

@@ -584 +584 @@
 bool QScriptValue::strictlyEquals(const QScriptValue& other) const
 {
-    return d_ptr == other.d_ptr || d_ptr->strictlyEquals(QScriptValuePrivate::get(other));
-}
+    return d_ptr->strictlyEquals(QScriptValuePrivate::get(other));
+}