Changeset 60661 in webkit for trunk/JavaScriptCore/qt/api/qscriptvalue.cpp

Timestamp:

Jun 4, 2010, 12:54:19 AM (15 years ago)

Author:

[email protected]

Message:

2010-06-04 Jedrzej Nowacki <​[email protected]>

Reviewed by Kenneth Rohde Christiansen.

Fix QScriptValue::equals.

Handling for a few edge cases were added. Now comparison between
NaN, an invalid objects should works as supposed.

[Qt] QScriptValue::equals problems
​https://bugs.webkit.org/show_bug.cgi?id=40110

• qt/api/qscriptvalue.cpp: (QScriptValue::equals):
• qt/api/qscriptvalue_p.h: (QScriptValuePrivate::equals):
• qt/tests/qscriptvalue/tst_qscriptvalue.h:
• qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_initData): (tst_QScriptValue::equals_makeData): (tst_QScriptValue::equals_test):

File:

• trunk/JavaScriptCore/qt/api/qscriptvalue.cpp (modified) (1 diff)

trunk/JavaScriptCore/qt/api/qscriptvalue.cpp

@@ -557 +557 @@
 bool QScriptValue::equals(const QScriptValue& other) const
 {
-    return d_ptr == other.d_ptr || d_ptr->equals(QScriptValuePrivate::get(other));
+    return d_ptr->equals(QScriptValuePrivate::get(other));
 }