Ignore:
Timestamp:
Jul 12, 2010, 9:41:13 AM (15 years ago)
Author:
[email protected]
Message:

Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions
​https://bugs.webkit.org/show_bug.cgi?id=42086

Reviewed by Dan Bernstein.

  • wtf/OwnPtr.h:
  • wtf/PassOwnPtr.h:
  • wtf/PassRefPtr.h:

(WTF::PassRefPtr::releaseRef):
(WTF::NonNullPassRefPtr::leakRef):
(WTF::NonNullPassRefPtr::releaseRef):

  • wtf/RetainPtr.h:

(WTF::RetainPtr::releaseRef):

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/wtf/PassRefPtr.h

    r62674 r63093  
    7878
    7979        void clear();
    80         T* leakRef() const;
     80        T* leakRef() const WARN_UNUSED_RETURN;
    8181
    8282        T& operator*() const { return *m_ptr; }
    … …  
    9797
    9898        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
    99         T* releaseRef() const { return leakRef(); }
     99        T* releaseRef() const { return leakRef(); } WARN_UNUSED_RETURN;
    100100
    101101    private:
    … …  
    153153
    154154        void clear();
    155         T* leakRef() const { T* tmp = m_ptr; m_ptr = 0; return tmp; }
     155        T* leakRef() const { T* tmp = m_ptr; m_ptr = 0; return tmp; } WARN_UNUSED_RETURN;
    156156
    157157        T& operator*() const { return *m_ptr; }
    … …  
    159159
    160160        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
    161         T* releaseRef() const { return leakRef(); }
     161        T* releaseRef() const { return leakRef(); } WARN_UNUSED_RETURN;
    162162
    163163    private:
Note: See TracChangeset for help on using the changeset viewer.