Changeset 63562 in webkit for trunk/JavaScriptCore/wtf/PassRefPtr.h

Timestamp:

Jul 16, 2010, 10:46:46 AM (15 years ago)

Author:

[email protected]

Message:

Really add WARN_UNUSED_RESULT to leakRef
​https://bugs.webkit.org/show_bug.cgi?id=42464

Reviewed by David Levin.

JavaScriptCore:

• wtf/PassRefPtr.h:

(WTF::PassRefPtr::):
(WTF::NonNullPassRefPtr::):
Put the WARN_UNUSED_RESULT attribute at the right place.

• wtf/RetainPtr.h:

(WTF::RetainPtr::releaseRef):
Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need
to be fixed first.

WebCore:

Get rid of a call to releaseRef here by passing the ScriptExecutionContext
reference through to the DerefContextTask.

• storage/Database.cpp:

(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::performTask):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):

File:

• trunk/JavaScriptCore/wtf/PassRefPtr.h (modified) (3 diffs)

trunk/JavaScriptCore/wtf/PassRefPtr.h

@@ -97 +97 @@
 
         // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
-        T* releaseRef() const { return leakRef(); } WARN_UNUSED_RETURN;
+        T* releaseRef() const WARN_UNUSED_RETURN { return leakRef(); }
 
     private:
@@ -153 +153 @@
 
         void clear();
-        T* leakRef() const { T* tmp = m_ptr; m_ptr = 0; return tmp; } WARN_UNUSED_RETURN;
+        T* leakRef() const WARN_UNUSED_RETURN { T* tmp = m_ptr; m_ptr = 0; return tmp; }
 
         T& operator*() const { return *m_ptr; }
@@ -159 +159 @@
 
         // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
-        T* releaseRef() const { return leakRef(); } WARN_UNUSED_RETURN;
+        T* releaseRef() const WARN_UNUSED_RETURN { return leakRef(); }
 
     private: